Opened 2 weeks ago

Closed 2 weeks ago

#30448 closed defect (fixed)

gtk2/libmozgtk.so is not stripped

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201905R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In projects/firefox/build we use this loop to strip and generate debuginfo for the firefox *.so files we include in the bundle:

for LIB in Browser/*.so Browser/firefox.real Browser/plugin-container Browser/updater

I think we should add gtk2/*.so to this loop.

In the same place we also remove the RUNPATH in case selfrando is used.

Child Tickets

Change History (5)

comment:1 Changed 2 weeks ago by boklm

Keywords: tbb-rbm TorBrowserTeam201905R added
Status: newneeds_review

comment:2 Changed 2 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Merged to master (commit 8b78ec43a5254776d8d4f3e98ef9f88aa48cc994)

comment:3 Changed 2 weeks ago by boklm

Resolution: fixed
Status: closedreopened

I forgot to create the Debug/Browser/gtk2 directory, so now it fails with:

objcopy:Debug/Browser/gtk2/libmozgtk.so: No such file or directory

This is fixed in branch bug_30448_v3:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_30448_v3&id=81a689dd863a4be72c4f3301cf571ac4146813f0

comment:4 Changed 2 weeks ago by boklm

Status: reopenedneeds_review

comment:5 Changed 2 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Nice fix. (And, yes, I should have caught the mistake, my bad :/). Pushed to master in commit 81a689dd863a4be72c4f3301cf571ac4146813f0.

Note: See TracTickets for help on using tickets.