Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#3045 closed defect (fixed)

We shouldn't log nodes by nickname

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Node nicknames are not unique, and not what people should be entering into their configurations. When we have any log messages that describes a node by its nickname alone, that's a problem. Instead, we should probably log something more like the node ID or the "extended node ID" format ($hexid~nickname), and maybe the node IP:ORPort too.

As we do this, we should also be careful about logging bridge addresses or node IDs.

Noted by OFFShare.

Child Tickets

Change History (4)

comment:1 Changed 8 years ago by nickm

Status: newneeds_review

There's one approach work in branch bug3045 in my public repository. Have a look!

comment:2 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

I tweaked it just a little bit to be more obviously safe, and am merging it into 0.2.2 and master.

comment:3 Changed 7 years ago by nickm

Keywords: tor-client added

comment:4 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.