Opened 2 weeks ago

Last modified 10 days ago

#30452 merge_ready enhancement

List which compile-time modules are enabled

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 040-backport? 035-backport?
Cc: Actual Points: 0
Parent ID: Points: .1
Reviewer: catalyst Sponsor:

Description

We should have a way to find out which compile-time modules Tor was built with.

Child Tickets

Change History (10)

comment:1 Changed 2 weeks ago by nickm

Actual Points: 0
Status: assignedneeds_review

See branch ticket30452_035 for this feature with PR at https://github.com/torproject/tor/pull/1009

See branch ticket30452_041 for a merge forward into 0.4.1 with a practracker update. PR at https://github.com/torproject/tor/pull/1010

comment:2 Changed 12 days ago by dgoulet

Reviewer: catalyst

comment:3 Changed 12 days ago by catalyst

Status: needs_reviewmerge_ready

Looks good! I commented on a minor style thing on the pull request.

comment:4 in reply to:  3 Changed 11 days ago by dgoulet

Status: merge_readyneeds_revision

Back in needs_revision. Left a comment as well on the 041 PR.

comment:5 Changed 11 days ago by nickm

Status: needs_revisionneeds_review

Both branches updated. Better now?

comment:6 Changed 11 days ago by nickm

Status: needs_reviewneeds_revision

oh wait, I was missing a comment.

comment:7 Changed 11 days ago by nickm

Status: needs_revisionneeds_review

Please see branch ticket30452_035_v2 with PR at https://github.com/torproject/tor/pull/1018

Also see branch ticket30452_041_v2 with PR at https://github.com/torproject/tor/pull/1019 . It is a simple merge forward into 0.4.1 with a practracker update.

comment:8 Changed 11 days ago by nickm

Branches are now ticket30453_035_v3 and ticket30452_041_v3. Respective PRs at https://github.com/torproject/tor/pull/1020 and https://github.com/torproject/tor/pull/1021 .

comment:9 Changed 10 days ago by catalyst

Status: needs_reviewmerge_ready

Thanks! The "v3" pull requests look good. (I had to restart a Travis build and an AppVeyor build due to transient failures.)

comment:10 Changed 10 days ago by dgoulet

Milestone: Tor: 0.4.1.x-finalTor: 0.4.0.x-final

Merged! Moving to the 040 milestone for possible backport.

Note: See TracTickets for help on using tickets.