Opened 13 days ago

Last modified 5 days ago

#30455 accepted defect

Does "make test-network-all" test every network twice?

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 035-backport?, 040-backport?, chutney, easy, tor-ci, 041-should
Cc: teor Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

It appears that in fb32c522320430f, we added a second call to test-network.sh inside our test-network-all loop. Now the code looks like this:

	for f in $$flavors; do \
		$(SHELL) $(top_srcdir)/test-driver --test-name $$f --log-file $(TEST_NETWORK_ALL_LOG_DIR)/$$f.log --trs-file $(TEST_NETWORK_ALL_LOG_DIR)/$$f.trs $(TEST_NETWORK_ALL_DRIVER_FLAGS) $(top_srcdir)/src/test/test-network.sh --flavor $$f $(TEST_NETWORK_FLAGS); \
		$(top_srcdir)/src/test/test-network.sh $(TEST_NETWORK_WARNING_FLAGS); \
	done; \

I might be wrong, but it looks to me like we're calling test-network.sh twice in each loop: once through test-driver, and once directly.

I'm not going to work on this till teor is back, though, since there are dragons here that I do not understand.

Child Tickets

Change History (3)

comment:1 Changed 6 days ago by nickm

Keywords: tor-ci added

comment:2 Changed 6 days ago by nickm

Keywords: 041-should added

comment:3 Changed 5 days ago by nickm

Owner: set to nickm
Status: newaccepted
Note: See TracTickets for help on using tickets.