Opened 2 months ago

#30458 new defect

CID 1444999 dead trunnel-generated code

Reported by: catalyst Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: coverity, trunnel
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This one looks valid to me, but also looks like it will need a trunnel change to the code generation for handling unions.

*** CID 1444999:  Control flow issues  (DEADCODE)
/src/trunnel/sendme.c: 244 in sendme_cell_encode()
238             break;
239         }
240         /* Write the length field back to data_len */
241         trunnel_assert(written >= written_before_union);
242     #if UINT16_MAX < SIZE_MAX
243         if (written - written_before_union > UINT16_MAX)
>>>     CID 1444999:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "goto check_failed;".
244           goto check_failed;
245     #endif
246         trunnel_set_uint16(backptr_data_len, trunnel_htons(written - written_before_union));
247       }
248     
249     

Child Tickets

Change History (0)

Note: See TracTickets for help on using tickets.