Opened 4 months ago

Last modified 2 days ago

#30460 needs_review defect

Update TOPL Project to Use Android Toolchain (Firefox 68)

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201909, TorBrowserTeam201909R
Cc: boklm, sisbell, gk Actual Points:
Parent ID: #30324 Points:
Reviewer: Sponsor: Sponsor44-can

Description

Update TOPL Project to use the new android toolchain. This will include updating gradle dependencies and changes to the api versions.

Child Tickets

Change History (19)

comment:1 Changed 3 months ago by gk

Keywords: TorBrowserTeam201906 added; TorBrowserTeam201905 removed

Moving tickets to June

comment:2 Changed 3 months ago by gk

Keywords: TorBrowserTeam201907 added; TorBrowserTeam201906 removed

Moving tickets to July

comment:4 Changed 2 months ago by sisbell

Cc: gk added

comment:5 Changed 2 months ago by gk

Keywords: TorBrowserTeam201907R added; TorBrowserTeam201907 removed

comment:6 Changed 2 months ago by cypherpunks

+ buildToolsVersion "27.0.3"
Making such patches means you're doing something really wrong (Mozilla too).
Docs say "your project automatically uses a default version of the build tools that the plugin specifies", but even 3.1.0 knows it's not 27.0.3, because you need 28.0.3 to "add support for building with API level 28".

comment:7 Changed 2 months ago by gk

Keywords: tbb-9.0-must-nightly added

Starting with 9.0 keywords

comment:8 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201908R added; TorBrowserTeam201907R removed

No July any longer.

comment:9 Changed 7 weeks ago by pili

Sponsor: Sponsor44-can

Adding Sponsor 44 to ESR68 tickets

comment:10 Changed 3 weeks ago by gk

Keywords: TorBrowserTeam201908 added; TorBrowserTeam201908R removed
Status: needs_reviewneeds_revision

Quoting from #30461:

 2) I doubt we still need export GRADLE_MAVEN_REPO="file://$gradle_repo" as the patches relying on that are gone?

3) How do I re-create the dependencies list? I tried now for a while but still failed. Please update the how-to-create-gradle-dependencies-list.txt so I can verify your work.

(There is no 1) here. :) )

You probably don't need to address 3) here if you do address it in #30461 already.

comment:12 Changed 3 weeks ago by sisbell

Status: needs_revisionneeds_review

comment:13 Changed 3 weeks ago by gk

Keywords: TorBrowserTeam201908R added; TorBrowserTeam201908 removed

comment:14 Changed 3 weeks ago by gk

Looks mostly good. I still need to verify the dependencies list which is blocked by #31568.

comment:15 Changed 3 weeks ago by gk

Keywords: tbb-9.0-must-alpha added; tbb-9.0-must-nightly removed

Move must-nightly items to must-alpha ones.

comment:16 Changed 3 weeks ago by gk

Keywords: TorBrowserTeam201909 added

Moving must-alpha tickets to September.

comment:17 Changed 3 weeks ago by gk

Moving tickets to September

comment:18 Changed 3 weeks ago by gk

Keywords: TorBrowserTeam201909R added; TorBrowserTeam201908R removed

No August anymore.

comment:19 in reply to:  14 Changed 2 days ago by gk

Replying to gk:

Looks mostly good. I still need to verify the dependencies list which is blocked by #31568.

One thing to note here is that the dependencies list is not sorted (it is for the tor-android-service project, though). I think we should fix that in a follow-up commit.

Note: See TracTickets for help on using tickets.