Opened 7 months ago

Closed 2 months ago

Last modified 42 hours ago

#30463 closed task (fixed)

Make sure telemetry reporting is disabled in Tor Browser 9

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201910R, BugSmashFund
Cc: Actual Points: 0.25
Parent ID: Points: 0.5
Reviewer: Sponsor:

Description

We explicitly unset telemetry reporting for mobile and have this disabled for desktop as well.

We should double-check this for Tor Browser 9, though, as MOZ_TELEMETRY_REPORTING gets now automatically set for builds using official settings (as we do), see https://bugzilla.mozilla.org/show_bug.cgi?id=1549886.

Child Tickets

Change History (12)

comment:1 Changed 4 months ago by pili

Sponsor: Sponsor44-can

Adding Sponsor 44 to ESR68 tickets

comment:2 Changed 3 months ago by gk

Keywords: TorBrowserTeam201909 tbb-9.0-must-alpha added

comment:3 Changed 3 months ago by pili

Points: 0.5

comment:4 Changed 2 months ago by pili

Keywords: TorBrowserTeam201910 added

comment:5 Changed 2 months ago by pili

Keywords: TorBrowserTeam201909 removed

comment:6 Changed 2 months ago by acat

Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: newneeds_review

I don't see any telemetry that is not already disabled by the prefs, but there's unnecessary code that is removed on build time when MOZ_TELEMETRY_REPORTING=0, and also it disables the telemetry section in about:preferences, making it impossible to enable. So I think it's good to have:

https://github.com/acatarineu/tor-browser/commit/30463

https://github.com/acatarineu/tor-browser-build/commit/30463

comment:7 Changed 2 months ago by gk

Keywords: TorBrowserTeam201910 added; TorBrowserTeam201910R removed
Status: needs_reviewneeds_revision

Thanks! Indeed, that's a good idea. I merged your tor-browser-build patch to master (commit 44d7ffc62c3df306a5e85d80d7607586f9c4d677). Could you make a !squash commit for tor-browser so we have all .mozconfig changes in one commit (af61067a0670be7c6a50ecd45ed062f2638ca9bc is the one on tor-browser-68.1.0esr-9.0-2 doing that currently)?

comment:8 Changed 2 months ago by acat

Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: needs_revisionneeds_review

comment:9 Changed 2 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good, thanks! Cherry-picked to tor-browser-68.1.0esr-9.0-2 (commit d9d5b02854f64cd638dd7215bf5d04b260116bb9)

comment:10 Changed 2 months ago by acat

Actual Points: 0.25

comment:11 Changed 42 hours ago by pili

Keywords: BugSmashFund added

BugSmashFund can be used for the ESR work done so far

comment:12 Changed 42 hours ago by pili

Sponsor: Sponsor44-can

Sponsor 44 only covered PM and Team Lead work

Note: See TracTickets for help on using tickets.