Opened 4 months ago

Closed 7 weeks ago

Last modified 6 weeks ago

#30468 closed enhancement (fixed)

Ship macedonian Tor Browser in alpha series

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: localization, TorBrowserTeam201907R, GeorgKoppen201907
Cc: gk, pili, emmapeel Actual Points:
Parent ID: #29935 Points:
Reviewer: Sponsor:

Description (last modified by arma)

The macedonian translation is in good shape it seems. Let's ship a macedonian Tor Browser in our alpha series.

Child Tickets

Change History (19)

comment:1 Changed 4 months ago by gk

Description: modified (diff)
Summary: Ship makedonian Tor Browser in alpha seriesShip macedonian Tor Browser in alpha series

comment:2 Changed 3 months ago by arma

Description: modified (diff)

(one more typo fix)

comment:3 Changed 3 months ago by emmapeel

Cc: emmapeel added
Keywords: localization added

comment:4 Changed 3 months ago by gk

Okay, it turns out there is no mk for mobile which is unfortunate and complicates things. I am not sure how we want to handle this situation. I guess, just ship for desktop then? Either way that won't be ready for 9.0a1 then, alas.

comment:5 Changed 3 months ago by Zarko_Gjurov

Hi there,

I am one of the translators and reviewers for Macedonian on Tor at Transifex.

I want to inform you that, all Macedonian translations needed for TOR are fully updated, translated and reviewed (only excluding Tails).

Also DTD TBA - Tor Browser for Android resource on Transifex is 100% translated and 100% reviewed, so there is a MK for mobile.

comment:6 in reply to:  5 Changed 3 months ago by gk

Replying to Zarko_Gjurov:

Hi there,

I am one of the translators and reviewers for Macedonian on Tor at Transifex.

I want to inform you that, all Macedonian translations needed for TOR are fully updated, translated and reviewed (only excluding Tails).

Also DTD TBA - Tor Browser for Android resource on Transifex is 100% translated and 100% reviewed, so there is a MK for mobile.

Yes, I saw that, thanks. What I meant was that *Mozilla* is shipping no mk strings, thus we can't ship a mobile mk Tor Browser either and need to route around that in our build scripts which assume that all locales are available in all platforms.

comment:7 in reply to:  5 Changed 3 months ago by emmapeel

Replying to Zarko_Gjurov:

I want to inform you that, all Macedonian translations needed for TOR are fully updated, translated and reviewed (only excluding Tails).

hi Zarko:

It would be great if you can also translate the Tor Browser User Manual and the Support Portal, which are resources needed by users with no English knowledge.

Thanks for your efforts, and your patience!

comment:8 Changed 3 months ago by gk

Keywords: GeorgKoppen201905 added

comment:9 Changed 2 months ago by gk

Keywords: TorBrowserTeam201906 added; TorBrowserTeam201905 removed

Moving tickets to June

comment:10 Changed 2 months ago by gk

Keywords: GeorgKoppen201906 added; GeorgKoppen201905 removed

Moving my tickets to June

comment:11 Changed 8 weeks ago by gk

Keywords: GeorgKoppen201907 added; GeorgKoppen201906 removed

Moving my tickets to July.

comment:12 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201907R added; TorBrowserTeam201906 removed
Status: newneeds_review

Alright, here come patches in three of my user repos up for review:

1) torbutton: bug_30468_v4 (https://gitweb.torproject.org/user/gk/torbutton.git/log/?h=bug_30468_v4)
2) tor-launcher: bug_30468_v2 (https://gitweb.torproject.org/user/gk/tor-launcher.git/commit/?h=bug_30468_v2&id=397253580d87f74447fe150f7336edcf4d816c79)
3) tor-browser-build: `bug_30468_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_30468_v2&id=27cd99e5978b3fe9db53ebecec5b97a3cd809c28) (thanks to boklm for the help here!)

FWIW as I said there is no mobile translation available, thus there won't be support for mk on mobile. Moreover, the onboarding extenion is not translated into mk either. Thus, all the strings from Firefox we use on desktop for our onboarding will be in en-US in a mk bundle.

comment:13 in reply to:  12 Changed 7 weeks ago by boklm

Replying to gk:

Alright, here come patches in three of my user repos up for review:

1) torbutton: bug_30468_v4 (https://gitweb.torproject.org/user/gk/torbutton.git/log/?h=bug_30468_v4)

This looks good to me.

2) tor-launcher: bug_30468_v2 (https://gitweb.torproject.org/user/gk/tor-launcher.git/commit/?h=bug_30468_v2&id=397253580d87f74447fe150f7336edcf4d816c79)

This looks good to me.

3) tor-browser-build: `bug_30468_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_30468_v2&id=27cd99e5978b3fe9db53ebecec5b97a3cd809c28) (thanks to boklm for the help here!)

This looks good to me. Although I misunderstood when talked about it on IRC, and was thinking that mk was for android only (instead of desktop only). Here is an alternative version of the patch that is a little more simple, skipping mk on android:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_30468&id=7b1c46d3649c20c91d4e33529412301e96ce2a0f

comment:14 Changed 7 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks for the review and the improved patch! I took yours for tor-browser-build (commit f16f8734b4834eaccd4d2c9dc018084f766b60f9) and merged the other patches to their respective repos (tor-launcher commit 397253580d87f74447fe150f7336edcf4d816c79 and torbutton commit 171b482609c7b8dc644150f4e83900bac715f071).

comment:15 Changed 6 weeks ago by Zarko_Gjurov

According to e-mail from Delphine Lebédel from Mozilla dated from Jul 6, 2019:
“Concerning the localization of Firefox for Android: we have not been adding new locales for a few months now which is why you can not request it on Pontoon. In fact, we are transitioning to the Fenix browser, and it makes no sense to start localizations now since it's a huge project that takes approximately at least 6 months to translate, and a year to reach release. By the time localization is complete, Firefox for Android will most surely not exist anymore.
Since Firefox for Android won't be here for much longer, I'm not really sure this effort still makes sense.”

So can you explain me what will happen with Macedonian translation for Tor according to this statement of Mozilla’s officials?

Keeping in mind that Tor MK translations were fully ready since last October, 2018, will be very unprofessional MK localization not to be published as final product.

So as I see Tor for Android will stay on EN-US while there will be Macedonian Tor bundle for Desktop released together with all other languages in v9.0, am I right, or?

comment:16 in reply to:  15 Changed 6 weeks ago by gk

Replying to Zarko_Gjurov:

According to e-mail from Delphine Lebédel from Mozilla dated from Jul 6, 2019:
“Concerning the localization of Firefox for Android: we have not been adding new locales for a few months now which is why you can not request it on Pontoon. In fact, we are transitioning to the Fenix browser, and it makes no sense to start localizations now since it's a huge project that takes approximately at least 6 months to translate, and a year to reach release. By the time localization is complete, Firefox for Android will most surely not exist anymore.
Since Firefox for Android won't be here for much longer, I'm not really sure this effort still makes sense.”

So can you explain me what will happen with Macedonian translation for Tor according to this statement of Mozilla’s officials?

Keeping in mind that Tor MK translations were fully ready since last October, 2018, will be very unprofessional MK localization not to be published as final product.

So as I see Tor for Android will stay on EN-US while there will be Macedonian Tor bundle for Desktop released together with all other languages in v9.0, am I right, or?

I think that is correct, yes. We are dependent on Mozilla for providing translations of all non-Tor Browser-strings (which take up the vast majority of browser strings). If those are not available we can't ship a bundle in the respective locale.

comment:17 Changed 6 weeks ago by Zarko_Gjurov

Since Firefox ESR for Desktop is available on Macedonian (MK) language for following platforms:

  • Windows 64-bit
  • Windows 32-bit
  • macOS
  • Linux 64-bit
  • Linux 32-bit

Does that mean that in Tor version 9.0 MK locale for TOR Browser for Desktop will be released (yes or no)?

comment:18 in reply to:  17 Changed 6 weeks ago by gk

Replying to Zarko_Gjurov:

Since Firefox ESR for Desktop is available on Macedonian (MK) language for following platforms:

  • Windows 64-bit
  • Windows 32-bit
  • macOS
  • Linux 64-bit
  • Linux 32-bit

Does that mean that in Tor version 9.0 MK locale for TOR Browser for Desktop will be released (yes or no)?

If we don't find any blocking issues while testing in the alpha series, then yes.

comment:19 Changed 6 weeks ago by boklm

Commit 7393339e1d9a569f4f57a98c3cd06aaffa6063f0 on the website is adding the mk locale for Tor Browser alpha:
https://gitweb.torproject.org/project/web/tpo.git/commit/?id=7393339e1d9a569f4f57a98c3cd06aaffa6063f0

Note: See TracTickets for help on using tickets.