Opened 2 months ago

Closed 7 weeks ago

Last modified 5 weeks ago

#30469 closed enhancement (fixed)

Ship romanian Tor Browser in alpha series

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: GeorgKoppen201905, TorBrowserTeam201906R
Cc: gk, pili Actual Points:
Parent ID: #29935 Points:
Reviewer: Sponsor:

Description

The romanian translation is in good shape it seems. Let's ship a romanian Tor Browser in our alpha series.

Child Tickets

Change History (8)

comment:1 Changed 2 months ago by gk

ro is busted differently on mobile due to missing escaping. :(

 0:16.08 :app:processOfficialWithoutGeckoBinariesNoMinApiPhotonDebugResources/var/tmp/build/firefox-7c7cbe719184/obj-arm-linux-androideabi/gradle/build/mobile/android/app/moz.build/src/officialWithoutGeckoBinariesNoMinApiPhotonDebug/res/values-ro/strings.xml:106:3-346: AAPT: Apostrophe not preceded by \ (in Serviciile Onion sunt site-uri a căror adresă se termină cu '.onion', ce oferă extra protecție atât celor care le publică  cât și celor care le vizitează, și care includ măsuri suplimentare împotriva cenzurii. Serviciile Onion permit oricui să procure conținut sau servicii în mod anonim.)
 0:16.08 
 0:16.08 /var/tmp/build/firefox-7c7cbe719184/obj-arm-linux-androideabi/gradle/build/mobile/android/app/intermediates/res/merged/officialWithoutGeckoBinariesNoMinApiPhoton/debug/values-ro/values-ro.xml:222: error: Apostrophe not preceded by \ (in Serviciile Onion sunt site-uri a căror adresă se termină cu '.onion', ce oferă extra protecție atât celor care le publică  cât și celor care le vizitează, și care includ măsuri suplimentare împotriva cenzurii. Serviciile Onion permit oricui să procure conținut sau servicii în mod anonim.)

comment:2 Changed 2 months ago by gk

Keywords: GeorgKoppen201905 added

comment:3 Changed 7 weeks ago by gk

Keywords: GeorgKoppen201905R added; GeorgKoppen201905 removed
Status: newneeds_review

comment:4 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201905R GeorgKoppen201905 added; TorBrowserTeam201905 GeorgKoppen201905R removed

comment:5 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201906R added; TorBrowserTeam201905R removed

Moving reviews over to June.

comment:6 Changed 7 weeks ago by acat

Looks good to me, although I didn't build the browser and test. Can do that if needed.

comment:7 Changed 7 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Okay, well, I've spent quite some time building so we should be good here. :) If disaster strikes we'll see it in tomorrow's nightly.

I merged the Torbutton patch to master (commit 534a42c9d8c57730dab0df9a1f77b2b5cc1d0b43), the Tor Launcher patch to master (commit e46bf3bf9f589bd48e13d39054be55f5dabd8842), and the tor-browser-build one to master (commit 919a7b230f0a88b600b02cd0d654cae1f69f0efb) (in the respective repositories).

Additionally, I picked up the Torbutton changes on tor-browser-60.7.0esr-9.0-1 for our nightly builds.

comment:8 Changed 5 weeks ago by boklm

I added the ro locale to the alpha download page on the website with commit 12e576c0f3b1eb26e450a8f371df11ab9dbbbcaa.

Note: See TracTickets for help on using tickets.