Opened 13 days ago

Closed 11 days ago

#30483 closed defect (fixed)

JCenter Can Cause Mismatched Hashes

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, TorBrowserTeam201905
Cc: sysrqb, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

JCenter functions as a proxy to one or more backend maven repos. Depending on the backend repo its using at the time, the checksum for an artifact may change.

Remove use of JCenter from tor-android-service gradle files

Child Tickets

Change History (5)

comment:1 Changed 13 days ago by sisbell

Status: newneeds_review

Fixed in branch 0512: https://github.com/sisbell/tor-android-service/commits/0512

comment:2 Changed 12 days ago by nobell

Why do you prefer http: to https:?

For consistency, it's better to add tor-android-service keyword to every ticket in a group. But it's not clear whether you're allowed to use keywords, beginning with tor-, as they belong to Tor team.

comment:3 Changed 12 days ago by nobell

BTW, if you want to get a review from the Tor Browser team, you should set TorBrowserTeam201905R keyword.

comment:4 Changed 12 days ago by gk

Keywords: TorBrowserTeam201905 added
Status: needs_reviewneeds_revision

Yes, please use https://. There is no official tor-android-service keyword yet, but if we think it's useful for tracking purposes I am fine using/creating it "officially". Setting the proper review keyword would help, yes, as it allows me to keep track of things easier and avoids patches which are falling through the cracks.

comment:5 Changed 11 days ago by gk

Resolution: fixed
Status: needs_revisionclosed

Fixed in commit 0bc3add0c73ab25fb29fa4710ebfc80ce09aa2f1 on master.

Note: See TracTickets for help on using tickets.