Opened 6 weeks ago

Closed 6 weeks ago

#30489 closed defect (fixed)

Remove Unused Resources from tor-android-service

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, tor-android-service, TorBrowserTeam201905
Cc: gk, sysrqb, n8fr8 Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

There are a number of resources not used by tor-android-service. Remove these.

Child Tickets

Change History (8)

comment:1 Changed 6 weeks ago by sisbell

There is a related PR for Orbot.

https://github.com/guardianproject/orbot/pull/213

comment:2 Changed 6 weeks ago by sisbell

Status: newneeds_review

Fixed in branch 0512: https://github.com/sisbell/tor-android-service/commits/0512

comment:3 Changed 6 weeks ago by gk

Keywords: TorBrowserTeam201905R added

comment:4 Changed 6 weeks ago by gk

Keywords: TorBrowserTeam201905 added; TorBrowserTeam201905R removed
Status: needs_reviewneeds_revision

It seems the added strings have some indentation issues like:

-  <string name="vpn_default_world">Dünya</string>
+    <string name="vpn_default_world">Dünya</string>

Could you please fix that? And out of curiosity, how did you determine all those strings are not needed anymore? Just grepping?

comment:5 in reply to:  4 Changed 6 weeks ago by sisbell

Replying to gk:

It seems the added strings have some indentation issues like:

-  <string name="vpn_default_world">Dünya</string>
+    <string name="vpn_default_world">Dünya</string>

Could you please fix that? And out of curiosity, how did you determine all those strings are not needed anymore? Just grepping?

There is a refactor code option for cleaning up resources in Android Studio. I just run that and then do inspections and searches to make sure its doing what I was expecting.

comment:6 Changed 6 weeks ago by sisbell

Branch 0514

  • Fixed the indentation issue

comment:7 Changed 6 weeks ago by nobell

What's wrong with you, sisbell? Set TorBrowserTeam201905R and needs_review appropriately.

comment:8 Changed 6 weeks ago by gk

Resolution: fixed
Status: needs_revisionclosed

Okay, this looks mostly good to me. Merged to master with commit 7da84f3e1f23edf26fbd8183a61ba4aedfe364fe. To save another roundtrip I pushed a fixup commit (28cc173eed552521a02b8edd94f4b7be8df7897f) to remove superfluous whitespace that suddenly showed up.

Note: See TracTickets for help on using tickets.