Remove Unused Resources from tor-android-service

There are a number of resources not used by tor-android-service. Remove these.

added TorBrowserTeam201905 component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-mobile tor-android-service type::defect labels

There is a related PR for Orbot.

!https://github.com/guardianproject/orbot/pull/213

Fixed in branch 0512: !https://github.com/sisbell/tor-android-service/commits/0512

Trac:
Status: new to needs_review

Trac:
Keywords: N/A deleted, TorBrowserTeam201905R added

It seems the added strings have some indentation issues like:

-  <string name="vpn_default_world">Dünya</string>
+    <string name="vpn_default_world">Dünya</string>

Could you please fix that? And out of curiosity, how did you determine all those strings are not needed anymore? Just grepping?

Trac:
Keywords: TorBrowserTeam201905R deleted, TorBrowserTeam201905 added
Status: needs_review to needs_revision

Replying to gk:

It seems the added strings have some indentation issues like: {{{

• Dünya

• Dünya }}} Could you please fix that? And out of curiosity, how did you determine all those strings are not needed anymore? Just grepping?

There is a refactor code option for cleaning up resources in Android Studio. I just run that and then do inspections and searches to make sure its doing what I was expecting.

Branch 0514

• Fixed the indentation issue

What's wrong with you, sisbell? Set TorBrowserTeam201905R and needs_review appropriately.

Trac:
Username: nobell

Okay, this looks mostly good to me. Merged to master with commit 7da84f3e1f23edf26fbd8183a61ba4aedfe364fe. To save another roundtrip I pushed a fixup commit (28cc173eed552521a02b8edd94f4b7be8df7897f) to remove superfluous whitespace that suddenly showed up.

Trac:
Status: needs_revision to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/tor-browser#30489 (closed)