Opened 15 months ago

Closed 11 months ago

Last modified 9 months ago

#30490 closed defect (fixed)

Add cbindgen project for building Firefox 68 ESR

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, ff68-esr, TorBrowserTeam201908, tbb-9.0-must-nightly, GeorgKoppen201908
Cc: boklm Actual Points:
Parent ID: #30320 Points:
Reviewer: Sponsor: Sponsor44-can

Description

We need to provide cbindgen for compiling Firefox. Right now it looks like we want to use 0.8.6, but actually whatever makes it into ESR 68.

Child Tickets

Change History (13)

comment:1 Changed 15 months ago by gk

https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=linux_esr68_v3&id=54d389f7d2c6275820391c7d79590b751eb17132 has some WIP to get this going on Linux at least. I hope we can at least be smarter around the vendoring here. I am not overly thrilled to add all the Windows related .a files given that we likely to need this as a host-only tool anyway (at least that's my hope).

comment:2 Changed 14 months ago by gk

Keywords: TorBrowserTeam201906 added; TorBrowserTeam201905 removed

Moving tickets to June

comment:3 Changed 14 months ago by gk

Keywords: GeorgKoppen201906 added; GeorgKoppen201905 removed

Moving my tickets to June

comment:4 Changed 14 months ago by gk

Keywords: GeorgKoppen201907 added; GeorgKoppen201906 removed

Moving my tickets to July.

comment:5 Changed 13 months ago by gk

Keywords: TorBrowserTeam201907 added; TorBrowserTeam201906 removed

Moving tickets to July

comment:6 Changed 13 months ago by gk

Keywords: tbb-9.0-must-nightly added

Starting with 9.0 keywords

comment:7 Changed 12 months ago by boklm

Keywords: TorBrowserTeam201908 added; TorBrowserTeam201907 removed
Status: newneeds_revision

As vendor.tar.gz is pretty big, I think we should move it outside the git repository, with something like this:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=linux_esr68_v5&id=7fdae3db547bc44f3b157d0f23f613f65a9cd0bf

I think we should also add some comment explaining how this file was created.

comment:8 Changed 12 months ago by pili

Sponsor: Sponsor44-can

Adding Sponsor 44 to ESR68 tickets

comment:9 in reply to:  7 ; Changed 12 months ago by gk

Replying to boklm:

As vendor.tar.gz is pretty big, I think we should move it outside the git repository, with something like this:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=linux_esr68_v5&id=7fdae3db547bc44f3b157d0f23f613f65a9cd0bf

Looks good. I cherry-picked that one and squashed the result onto master (commit a61d68dc37a39d0aca74b273ca2b444fe33a07dc)

I think we should also add some comment explaining how this file was created.

I agree. I am leaving this ticket open for that comment and I still like to get the vendoring result smaller if possible...

comment:10 Changed 12 months ago by cypherpunks

As vendor.tar.gz is pretty big, I think we should move it outside the git repository

Why? It looks like something similar to ICU BLOB.

comment:11 Changed 12 months ago by gk

Keywords: GeorgKoppen201908 added; GeorgKoppen201907 removed

Move my tickets.

comment:12 Changed 11 months ago by gk

Resolution: fixed
Status: needs_revisionclosed

Commit 84d95d6d2a51d93f62e9927cfa2e63e674066c7d adapted the build script for 32bit Windows. We are done here. I opened #31588 about us hopefully being smarter about the vendoring in the future..

comment:13 in reply to:  9 Changed 9 months ago by gk

Replying to gk:

Replying to boklm:

As vendor.tar.gz is pretty big, I think we should move it outside the git repository, with something like this:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=linux_esr68_v5&id=7fdae3db547bc44f3b157d0f23f613f65a9cd0bf

Looks good. I cherry-picked that one and squashed the result onto master (commit a61d68dc37a39d0aca74b273ca2b444fe33a07dc)

I think we should also add some comment explaining how this file was created.

I agree. I am leaving this ticket open for that comment and I still like to get the vendoring result smaller if possible...

The latter did not happen yet (it could be part of #31588) and the former is #32509.

Note: See TracTickets for help on using tickets.