Opened 7 months ago

Closed 7 months ago

#30492 closed enhancement (fixed)

Switch to OpenSSL 1.1.1 series for Tor Browser

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201905R, GeorgKoppen201905
Cc: Actual Points:
Parent ID: Points:
Reviewer: boklm Sponsor:

Description

We are currently on the 1.0.2 series but that is EOL at the end of this year. We should start testing OpenSSL 1.1.1 soon, so we are good using it with Tor Browser 9.

Child Tickets

Change History (7)

comment:1 Changed 7 months ago by gk

Parent ID: #30320

comment:2 Changed 7 months ago by gk

Keywords: TorBrowserTeam201905R GeorgKoppen201905 added; TorBrowserTeam201905 removed

bug_30492_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_30492_v2&id=fd2e14350a87b3057399d1567a80928bc3473713) is up for review. The commit is on top of the ones for #30491 and #30536 to test whether there are any issues with the OpenSSL upgrade after the macOS host system upgrade. I did not run into any. I tested the resulting Linux and Windows builds and found no problems while using Tor Browser.

comment:3 Changed 7 months ago by gk

Status: newneeds_review

comment:4 Changed 7 months ago by boklm

Reviewer: boklm

comment:5 Changed 7 months ago by boklm

Keywords: TorBrowserTeam201905 added; TorBrowserTeam201905R removed
Status: needs_reviewneeds_revision

Building tor for linux-x86_64 with this patch, I get the following error:

cp: cannot stat `/var/tmp/dist/openssl/lib/libssl.so.1.0.0': No such file or directory

So it looks like we need to update the libssl.so filename in projects/tor/build.

comment:6 in reply to:  5 ; Changed 7 months ago by gk

Keywords: TorBrowserTeam201905R added; TorBrowserTeam201905 removed
Status: needs_revisionneeds_review

Replying to boklm:

Building tor for linux-x86_64 with this patch, I get the following error:

cp: cannot stat `/var/tmp/dist/openssl/lib/libssl.so.1.0.0': No such file or directory

So it looks like we need to update the libssl.so filename in projects/tor/build.

Huh, I hit that when testing a first patch, but it seems when I put that one on top of the other patches (see: comment:2) I forgot to add the fixup commit. :( Sorry for that. This is fixed on bug_30492_v3 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_30492_v3&id=2fba118f50c4bb3418787cdca5a021d5941841b6).

comment:7 in reply to:  6 Changed 7 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

Replying to gk:

Replying to boklm:

Building tor for linux-x86_64 with this patch, I get the following error:

cp: cannot stat `/var/tmp/dist/openssl/lib/libssl.so.1.0.0': No such file or directory

So it looks like we need to update the libssl.so filename in projects/tor/build.

Huh, I hit that when testing a first patch, but it seems when I put that one on top of the other patches (see: comment:2) I forgot to add the fixup commit. :( Sorry for that. This is fixed on bug_30492_v3 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_30492_v3&id=2fba118f50c4bb3418787cdca5a021d5941841b6).

This looks good to me. This is now commit 2fba118f50c4bb3418787cdca5a021d5941841b6 on master.

Note: See TracTickets for help on using tickets.