Opened 3 months ago

Last modified 3 weeks ago

#30501 new defect

BridgesList Preferences is an overloaded field

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, TorBrowserTeam201905
Cc: igt0, sisbell, sysrqb, hans@…, n8fr8 Actual Points:
Parent ID: #31280 Points:
Reviewer: Sponsor: Sponsor30-can

Description

BridgesList is an overloaded field, which can cause some confusion. The list can be:

  1. a filter like obfs4 or meek OR  
  2. can be a custom bridge

For (1), we just pass back all bridges, the filter will occur elsewhere in the library. For (2) we return the bridge list as a raw stream. If length is greater than 5, then we know this is a custom bridge

We should fix this so that we have separate preferences for 1 and 2. We also shouldn't be looking at string length to determine field type.

Child Tickets

Change History (5)

comment:1 Changed 3 months ago by sisbell

Keywords: tbb-8.5-must removed

comment:2 Changed 3 weeks ago by pili

Parent ID: #31280

comment:3 Changed 3 weeks ago by pili

Sponsor: Sponsor30-can

comment:4 Changed 3 weeks ago by pili

Parent ID: #31280#31349

comment:5 Changed 3 weeks ago by pili

Parent ID: #31349#31280
Note: See TracTickets for help on using tickets.