Deterministic coverage on 0.4.1

I'd like us to have useful coverage diffs again.

changed milestone to %Tor: 0.4.1.x-final

added 041-should actualpoints::1 component::core tor/tor dgoulet-merge milestone::Tor: 0.4.1.x-final owner::nickm priority::medium resolution::fixed reviewer::ahf severity::normal status::closed tor-ci type::defect labels

I have a start here in a branch called coverage-fixes but I'll need to wait till #28878 (moved) is merged before I make it needs_review.

Trac:
Keywords: N/A deleted, tor-ci added

Trac:
Keywords: N/A deleted, 041-should added

See branch coverage-fixes with PR at https://github.com/torproject/tor/pull/1047 .

Some of the changes here won't affect coveralls, but only gcov. The biggest one is that I want to remove test_rebind from the list of tests that count for coverage: it invokes the Tor mainloop, and because of that, causes a pretty huge amount of code to run without actually testing any of it.

Trac:
Status: assigned to needs_review
Actualpoints: N/A to 1

Trac:
Reviewer: N/A to ahf

Neat. Let's get it in.

Trac:
Status: needs_review to merge_ready

Trac:
Keywords: N/A deleted, dgoulet-merge added

Merged in 041!

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

closed

added 8h of time spent

moved to tpo/core/tor#30519 (closed)