Opened 4 months ago

Closed 4 months ago

#30519 closed defect (fixed)

Deterministic coverage on 0.4.1

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-ci, 041-should, dgoulet-merge
Cc: Actual Points: 1
Parent ID: Points:
Reviewer: ahf Sponsor:

Description

I'd like us to have useful coverage diffs again.

Child Tickets

Change History (8)

comment:1 Changed 4 months ago by nickm

I have a start here in a branch called coverage-fixes but I'll need to wait till #28878 is merged before I make it needs_review.

comment:2 Changed 4 months ago by nickm

Keywords: tor-ci added

comment:3 Changed 4 months ago by nickm

Keywords: 041-should added

comment:4 Changed 4 months ago by nickm

Actual Points: 1
Status: assignedneeds_review

See branch coverage-fixes with PR at https://github.com/torproject/tor/pull/1047 .

Some of the changes here won't affect coveralls, but only gcov. The biggest one is that I want to remove test_rebind from the list of tests that count for coverage: it invokes the Tor mainloop, and because of that, causes a pretty huge amount of code to run without actually testing any of it.

comment:5 Changed 4 months ago by dgoulet

Reviewer: ahf

comment:6 Changed 4 months ago by ahf

Status: needs_reviewmerge_ready

Neat. Let's get it in.

comment:7 Changed 4 months ago by nickm

Keywords: dgoulet-merge added

comment:8 Changed 4 months ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

Merged in 041!

Note: See TracTickets for help on using tickets.