Opened 6 weeks ago

Closed 3 weeks ago

#30525 closed defect (fixed)

relaydescs sync module does not work for bandwidth files

Reported by: irl Owned by: karsten
Priority: Medium Milestone:
Component: Metrics/CollecTor Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor:

Description

The @type annotation is not recognised and so while the files are discovered, they always turn up as UnparseableDescriptors and are not stored.

Child Tickets

Change History (10)

comment:1 Changed 6 weeks ago by karsten

Cc: metrics-team added
Owner: changed from metrics-team to karsten
Status: newaccepted

Ah, I'm already working on this. Grabbing the ticket.

comment:2 Changed 6 weeks ago by irl

Ok cool. I need to redo the box that I was using to give it a bigger disk, but can deploy there once it's ready so we can detect any more issues before we need to use the sync code.

comment:4 Changed 6 weeks ago by irl

Reviewer: irl

comment:5 Changed 5 weeks ago by irl

karsten: Do you happen to know if syncing microdescriptors ever worked? I've noticed in testing that only microdescriptor consensuses are synced, but not the microdescriptors.

comment:6 Changed 5 weeks ago by karsten

Nope, syncing microdescriptors never worked. The underlying issue is that they lack a publication timestamp, which makes it really hard to sort them into monthly folders. The way we do this in the "Remote" mode is that we parse microdescriptor consensuses and remember microdescriptor digests and microdescriptor consensus valid-after times. (A side effect is that microdescriptors may be included in two subsequent monthly folders.) However, this seemed rather complex to replicate for the "Sync" mode which is why we didn't implement that. It would be nice to fix this somehow, though it seemed like a lower-priority thing to do at the time.

comment:7 Changed 5 weeks ago by irl

Status: needs_reviewmerge_ready

Ok. Then everything is working as expected.

https://collector.irl1.net/recent/relay-descriptors/bandwidths/

Both the metrics-lib and collector branches look good to me.

comment:8 Changed 4 weeks ago by irl

Reviewer: irl

We should get these changes merged so that we can make a release and plan for deployment next week.

comment:9 Changed 4 weeks ago by karsten

Oh! I somehow didn't notice that this is already ready to merge. Oops. Merged the metrics-lib patch and preparing the release now. The CollecTor patch and release will be next.

comment:10 Changed 3 weeks ago by irl

Resolution: fixed
Status: merge_readyclosed
Note: See TracTickets for help on using tickets.