Opened 4 months ago

Closed 5 days ago

#30527 closed defect (worksforme)

Fix coverity warnings in test_parsecommon.c

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: coverity technical-debt 042-should
Cc: Actual Points: 0.1
Parent ID: Points: .5
Reviewer: teor Sponsor: Sponsor31-can

Description

Coverity warns incorrectly about a few places in test_parsecommon.c. We'll probably need to refactor the underlying code to solve this one, so it won't be a trivial fix. It should wait for 0.4.2. Because it will clean up some ugliness, it is S31.

Child Tickets

Change History (6)

comment:1 Changed 2 weeks ago by nickm

Actual Points: 0
Status: assignedneeds_review

Coverity is no longer warning here. Either we fixed this stuff in some unexpected way, or it was a false positive?

Putting in needs_review for somebody who groks the coverity UI to confirm.

comment:2 Changed 13 days ago by dgoulet

Reviewer: #30527

comment:3 Changed 12 days ago by dgoulet

Reviewer: #30527teor

comment:4 Changed 11 days ago by nickm

Keywords: 042-should added

comment:5 Changed 5 days ago by teor

I don't have a copy of the coverity email with these defects: it may have been eaten by a spam filter.
(In future, let's copy the defect text into the ticket?)

I'll use the online interface to check for coverity issues in test_parsecommon.c from approximately May 2019.

comment:6 Changed 5 days ago by teor

Actual Points: 00.1
Resolution: worksforme
Status: needs_reviewclosed

I spent some time searching for this coverity issue, and I couldn't find it.
Coverity has purged all historical source code and metadata, so it may be impossible to locate it.

However, I have confirmed that it is not a current open issue in coverity.

Note: See TracTickets for help on using tickets.