Opened 4 weeks ago

Closed 9 days ago

#30550 closed defect (implemented)

Remove torctl.in from contrib/dist

Reported by: rl1987 Owned by:
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

This file was introduced in 2004 (acb2c10a5bd99bac12f07f476e3f016b4277dbbf) and last touched during maintenance activities in 2014 (9230bc7c65cec68c66fa9c75751d6c6bd600e9fc). I suggest we remove it, so that we get closer to covering all of our shellscripts with shellcheck.

Child Tickets

Change History (5)

comment:2 Changed 4 weeks ago by rl1987

Status: newneeds_review

comment:3 Changed 3 weeks ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready

This is not shipped afaict in our packages so I don't see much harm especially it hasn't changed so anyone using it today basically shouldn't notice it is gone from the repo.

comment:4 Changed 3 weeks ago by nickm

Milestone: Tor: unspecifiedTor: 0.4.2.x-final

Let's merge this in 0.4.2; I'd rather not remove stuff later than the first alpha in a series unless it's really compelling to do so.

comment:5 Changed 9 days ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.