Opened 3 months ago

Closed 3 months ago

#30560 closed defect (fixed)

Onboarding toolbar graphic doesn't match actual toolbar after upgrade

Reported by: sysrqb Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-onboarding, tbb-8.5-issues, TorBrowserTeam201905R
Cc: pospeselr, antonela, mcs, brade, acat Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

One of my installations just updated to 8.5, but the Onboarding screen doesn't match the actual toolbar.

Child Tickets

Attachments (7)

TorBrowser85_toolbar.png (50.8 KB) - added by sysrqb 3 months ago.
figure_tor-toolbar-layout.png (10.8 KB) - added by antonela 3 months ago.
figure_tor-toolbar-layout@2x.png (26.1 KB) - added by antonela 3 months ago.
figure_tor-toolbar-layout.2.png (10.3 KB) - added by antonela 3 months ago.
figure_tor-toolbar-layout2.png (11.0 KB) - added by antonela 3 months ago.
figure_tor-toolbar-layout2@2x.png (26.1 KB) - added by antonela 3 months ago.
figure_tor-toolbar-layout@2x.2.png (25.0 KB) - added by antonela 3 months ago.

Download all attachments as: .zip

Change History (22)

Changed 3 months ago by sysrqb

Attachment: TorBrowser85_toolbar.png added

comment:1 Changed 3 months ago by gk

Cc: pospeselr antonela added

Well, the problem here is that the toolbar is essentially user customizable as e.g. can be seen on your image with the search bar which is not enabled by default in Firefox/Tor Browser. So, what do we do then? We made the decision to not mess with the toolbar for installed Tor Browser versions, but rather customize it only for new Tor Browsers as we want.

Yes, this leaves the Noscript icon and the HTTPS-Everywhere icon on for those users that still have those on the toolbar. I think there is not much more we can do here without risking serious interference with user customizations. Thus, I am inclined to just live with that and mark this as WONTFIX.

comment:2 Changed 3 months ago by sysrqb

yes, that is understandable - so the new toolbar layout is only used in new installations because we don't want to modify any customizations. I'm more concerned about the onboarding graphic not matching the real toolbar. I don't know how that should be corrected. Maybe deleting the hamburger icon will help? After I looked at that graphic, then I looked up at the hamburger icon and expected to see the onion and shield icons there - but they weren't there. They were on the other side of the search box. I found this confusing.

comment:3 Changed 3 months ago by sysrqb

Summary: NoScript and HTTPS-E remain in toolbarOnboarding toolbar graphic doesn't match actual toolbar after uprgade

I'll change the title.

comment:4 Changed 3 months ago by sysrqb

Summary: Onboarding toolbar graphic doesn't match actual toolbar after uprgadeOnboarding toolbar graphic doesn't match actual toolbar after upgrade

and typo.

comment:5 in reply to:  2 ; Changed 3 months ago by gk

Cc: mcs brade added
Keywords: tbb-onboarding tbb-8.5-issues added

Replying to sysrqb:

yes, that is understandable - so the new toolbar layout is only used in new installations because we don't want to modify any customizations. I'm more concerned about the onboarding graphic not matching the real toolbar. I don't know how that should be corrected. Maybe deleting the hamburger icon will help? After I looked at that graphic, then I looked up at the hamburger icon and expected to see the onion and shield icons there - but they weren't there. They were on the other side of the search box. I found this confusing.

Yes, it is. The logic says the icons get inserted after the URL bar. So, given we have only one image showing the new icons during the onboarding, what we did was taking a vanilla Tor Browser 8 as we ship it and go from that one. That might get confusing for users who customized their toolbar and added the search box, yes. It might even be confusing for users that still have an old Tor Browser that originally shipped with the search bar and just used the internal updater every time until 8.5 now. Still, I am not sure how we can know what the user's toolbar layout looks like and show the respective image. Or maybe, on second thought, the onboarding logic could actually figure that out and show the proper image out of, say, three scenarios we would take care of? But then again, that's quite some work to do. :)

comment:6 in reply to:  5 ; Changed 3 months ago by sysrqb

Replying to gk:

It might even be confusing for users that still have an old Tor Browser that originally shipped with the search bar and just used the internal updater every time until 8.5 now.

And this is my situation.

Still, I am not sure how we can know what the user's toolbar layout looks like and show the respective image. Or maybe, on second thought, the onboarding logic could actually figure that out and show the proper image out of, say, three scenarios we would take care of? But then again, that's quite some work to do. :)

Yes, I don't claim I have the correct answer :) Maybe a different graphic showing the awesomebar and the new shield+onion icons instead of the current one showing the corner of the browser with "a textbox" and the three buttons? I'm imagining moving the focus of the graphic from the corner of the browser window to the awesomebar and onion+shield buttons. I don't know if this makes sense, though.

comment:7 in reply to:  6 Changed 3 months ago by gk

Replying to sysrqb:

Replying to gk:

It might even be confusing for users that still have an old Tor Browser that originally shipped with the search bar and just used the internal updater every time until 8.5 now.

And this is my situation.

Still, I am not sure how we can know what the user's toolbar layout looks like and show the respective image. Or maybe, on second thought, the onboarding logic could actually figure that out and show the proper image out of, say, three scenarios we would take care of? But then again, that's quite some work to do. :)

Yes, I don't claim I have the correct answer :) Maybe a different graphic showing the awesomebar and the new shield+onion icons instead of the current one showing the corner of the browser with "a textbox" and the three buttons? I'm imagining moving the focus of the graphic from the corner of the browser window to the awesomebar and onion+shield buttons. I don't know if this makes sense, though.

Yes, that's a good idea.

Changed 3 months ago by antonela

Changed 3 months ago by antonela

comment:8 Changed 3 months ago by antonela

Thanks both! I attached a new image without the hamburger menu to incorporate users who have more icons at the toolbar.

https://trac.torproject.org/projects/tor/raw-attachment/ticket/30560/figure_tor-toolbar-layout.png

Last edited 3 months ago by antonela (previous) (diff)

comment:9 Changed 3 months ago by gk

Looking over the images I think we should do the same update for the security slider image? There the icons are shown next to the hamburger menu as well. Do we know whether the @2x image is actually picked up in the onboarding context? So far, we only had the "normal" .png one.

comment:10 Changed 3 months ago by Thorin

Or insert the bookmark star into the graphic (the one inside but at the end of the urlbar) ... as shown in the example by OP. If you're in the onboarding this will be shown. This now gives the user a visual reference - not to mention the text says it goes after the urlbar.

Last edited 3 months ago by Thorin (previous) (diff)

comment:11 in reply to:  9 ; Changed 3 months ago by mcs

Replying to gk:

Looking over the images I think we should do the same update for the security slider image? There the icons are shown next to the hamburger menu as well.

Agreed.

Do we know whether the @2x image is actually picked up in the onboarding context? So far, we only had the "normal" .png one.

Until we fix #27357, we cannot use @2x images.

Changed 3 months ago by antonela

Changed 3 months ago by antonela

Changed 3 months ago by antonela

Changed 3 months ago by antonela

comment:12 in reply to:  11 Changed 3 months ago by antonela

Replying to mcs:

Replying to gk:

Looking over the images I think we should do the same update for the security slider image? There the icons are shown next to the hamburger menu as well.

Agreed.

Done. Feel free to grab the attachments.

https://trac.torproject.org/projects/tor/raw-attachment/ticket/30560/figure_tor-toolbar-layout2@2x.png

comment:13 Changed 3 months ago by gk

Cc: acat added
Keywords: TorBrowserTeam201905R added
Status: newneeds_review

comment:14 Changed 3 months ago by acat

Looks good to me.

comment:15 Changed 3 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Merged to tor-browser-60.7.0esr-9.0-1 (commit 79286b37dd0d3711a5ef029e15286cf37339cba6) and cherry-picked to tor-browser-60.7.0esr-8.5-1 (commit 70d0b16f9f23c81040b6648a813c0991315afdb8).

Note: See TracTickets for help on using tickets.