Add Fundraising Banner with next TBB security update

Let's plan to add a fundraising banner with the next TBB security update (TBB 8.5.3) which should happen around 2019-07-09.

The banner should come off on the following TBB security update, which should happen around 2019-09-03.

added TorBrowserTeam201907R component::applications/tor browser owner::tbb-team priority::high resolution::fixed severity::normal status::closed type::task ux-team labels

I wonder if we can re-use the code/implementation from the end of year banner. If yes, I'll prepare some versions based on it.

We've tentatively decided to promote monthly giving and include the patch image for this banner

The banner should be removed on the following security update around 09/03

Replying to antonela:

I wonder if we can re-use the code/implementation from the end of year banner. If yes, I'll prepare some versions based on it.

I guess that depends on how the fundraising banner should look like and behave. If it should be essentially the same functionality/look, then yes.

Trac:
Priority: Medium to High
Keywords: N/A deleted, TorBrowserTeam201906 added

Trac:
Description: Let's plan to add a fundraising banner with the next TBB security update (TBB 8.5.2?) which should happen on 2019-07-09

to

Let's plan to add a fundraising banner with the next TBB security update (TBB 8.5.3) which should happen around 2019-07-09.

The banner should come off on the following TBB security update, which should happen around 2019-09-03.

Art: Defenders of Privacy logo or image of patch

Link to: https://donate.torproject.org/monthly-giving

Proposed copy: Automatic monthly donations keep Tor strong. Become a Defender of Privacy today.

Proposed functionality: Each user will see the banner three times. Any user that Xs out of the banner will not see it again.

Once the copy is frozen we will need to let emmapeel know to coordinate translations

Trac:
Cc: sstevenson, antonela to sstevenson, antonela, emmapeel

The copy looks good to me.

Trac:


Is that the final banner we should use on desktop and mobile? If so, could we get all the assets needed so we can get the work started for this ticket?

Trac:
Status: new to needs_information

Trac:
icon_monthly_donors.zip

I think the banner looks great. Can we maintain the newsletter signup link on this page under "Questions"?

Patch for review: https://github.com/acatarineu/torbutton/commit/30577

Note: did not find the translations, I am assuming they are not ready yet. Will update the patch once they are.

Trac:
Status: needs_information to needs_review
Keywords: TorBrowserTeam201906 deleted, TorBrowserTeam201907R added

Trac:

Trac:

Trac:

Some comments:

I am a bit wary using extensions.torbutton.donation_banner_countdown as we had this one already in our last year-end-campaign and some users might still have this pref set to 0 in their profile. I guess we can use extensions.torbutton.donation_banner_countdown3 instead?

Nit: // Show the Sign Up for Tor News banner a finite number of times. no Tor News here but the donation banner.

Re the language strings: The usual flow is defining the necessary ones for en-US and commit that and then the translations get done/added once they are ready. Thus, creating proper entries in aboutTor.dtd seems to be the way forward. I guess that could mean two entries for the two sentences, like aboutTor.donationBanner3.line1 and aboutTor.donationBanner3.line2, given that we only want to make the second one a link?

Trac:
Status: needs_review to needs_revision
Keywords: TorBrowserTeam201907R deleted, TorBrowserTeam201907 added

Thanks. Addressed comments here: https://github.com/acatarineu/torbutton/commit/30577+1

Trac:
Status: needs_revision to needs_review
Keywords: TorBrowserTeam201907 deleted, TorBrowserTeam201907R added

Replying to acat:

Thanks. Addressed comments here: https://github.com/acatarineu/torbutton/commit/30577+1

Looks good. I think one final tweak we want to do is not counting down if the user just clicks the link. We only count down if they click the "x" or do a restart.

Trac:
Status: needs_review to needs_revision
Keywords: TorBrowserTeam201907R deleted, TorBrowserTeam201907 added

Fixed in https://github.com/acatarineu/torbutton/commit/30577+2

Trac:
Status: needs_revision to needs_review

Thanks! We are done here. I merged the branch to torbutton's master (commit 1f05efdb50291d26e7e52d07f3bddabf86ee7796) and updated the translations so our next localized nightly builds are not busted (commit fc5f85c225f7518b078ca20457468e38a78430ad). And I bumped the Torbutton commit we use in the tor-browser repo submodule so we have the changes available on mobile, too. (see tor-browser-60.7.0esr-9.0-1 (commit c8dce5f0a165026ecacec69132b568876916ddc1))

Trac:
Resolution: N/A to fixed
Status: needs_review to closed
Keywords: TorBrowserTeam201907 deleted, TorBrowserTeam201907R added

closed

mentioned in issue #30915 (moved)

moved to tpo/applications/tor-browser#30577 (closed)