Opened 7 months ago

Closed 6 months ago

#30577 closed task (fixed)

Add Fundraising Banner with next TBB security update

Reported by: pili Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ux-team, TorBrowserTeam201907R
Cc: sstevenson, antonela, emmapeel Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by pili)

Let's plan to add a fundraising banner with the next TBB security update (TBB 8.5.3) which should happen around 2019-07-09.

The banner should come off on the following TBB security update, which should happen around 2019-09-03.

Child Tickets

Attachments (5)

TB8 - Snippet - Top - White - Icon Color.png (336.3 KB) - added by antonela 6 months ago.
icon_monthly_donors.zip (25.4 KB) - added by antonela 6 months ago.
320px.png (40.0 KB) - added by acat 6 months ago.
375px.png (113.0 KB) - added by acat 6 months ago.
desktop_on.png (88.6 KB) - added by acat 6 months ago.

Download all attachments as: .zip

Change History (23)

comment:1 Changed 6 months ago by antonela

I wonder if we can re-use the code/implementation from the end of year banner. If yes, I'll prepare some versions based on it.

comment:2 Changed 6 months ago by pili

We've tentatively decided to promote monthly giving and include the patch image for this banner

The banner should be removed on the following security update around 09/03

comment:3 in reply to:  1 Changed 6 months ago by gk

Replying to antonela:

I wonder if we can re-use the code/implementation from the end of year banner. If yes, I'll prepare some versions based on it.

I guess that depends on how the fundraising banner should look like and behave. If it should be essentially the same functionality/look, then yes.

comment:4 Changed 6 months ago by gk

Keywords: TorBrowserTeam201906 added
Priority: MediumHigh

comment:5 Changed 6 months ago by pili

Description: modified (diff)

comment:6 Changed 6 months ago by pili

Art: Defenders of Privacy logo or image of patch

Link to: https://donate.torproject.org/monthly-giving

Proposed copy: Automatic monthly donations keep Tor strong. Become a Defender of Privacy today.

Proposed functionality: Each user will see the banner three times. Any user that Xs out of the banner will not see it again.

Last edited 6 months ago by pili (previous) (diff)

comment:7 Changed 6 months ago by pili

Cc: emmapeel added

Once the copy is frozen we will need to let emmapeel know to coordinate translations

comment:8 Changed 6 months ago by steph

The copy looks good to me.

Changed 6 months ago by antonela

comment:9 Changed 6 months ago by antonela

https://trac.torproject.org/projects/tor/raw-attachment/ticket/30577/TB8%20-%20Snippet%20-%20Top%20-%20White%20-%20Icon%20Color.png

comment:10 Changed 6 months ago by gk

Status: newneeds_information

Is that the final banner we should use on desktop and mobile? If so, could we get all the assets needed so we can get the work started for this ticket?

Changed 6 months ago by antonela

Attachment: icon_monthly_donors.zip added

comment:11 Changed 6 months ago by sstevenson

I think the banner looks great. Can we maintain the newsletter signup link on this page under "Questions"?

comment:12 Changed 6 months ago by acat

Patch for review: https://github.com/acatarineu/torbutton/commit/30577

Note: did not find the translations, I am assuming they are not ready yet. Will update the patch once they are.

comment:13 Changed 6 months ago by acat

Keywords: TorBrowserTeam201907R added; TorBrowserTeam201906 removed
Status: needs_informationneeds_review

Changed 6 months ago by acat

Attachment: 320px.png added

Changed 6 months ago by acat

Attachment: 375px.png added

Changed 6 months ago by acat

Attachment: desktop_on.png added

comment:14 Changed 6 months ago by gk

Keywords: TorBrowserTeam201907 added; TorBrowserTeam201907R removed
Status: needs_reviewneeds_revision

Some comments:

I am a bit wary using extensions.torbutton.donation_banner_countdown as we had this one already in our last year-end-campaign and some users might still have this pref set to 0 in their profile. I guess we can use extensions.torbutton.donation_banner_countdown3 instead?

Nit: // Show the Sign Up for Tor News banner a finite number of times. no Tor News here but the donation banner.

Re the language strings: The usual flow is defining the necessary ones for en-US and commit that and then the translations get done/added once they are ready. Thus, creating proper entries in aboutTor.dtd seems to be the way forward. I guess that could mean two entries for the two sentences, like aboutTor.donationBanner3.line1 and aboutTor.donationBanner3.line2, given that we only want to make the second one a link?

comment:15 Changed 6 months ago by acat

Keywords: TorBrowserTeam201907R added; TorBrowserTeam201907 removed
Status: needs_revisionneeds_review

comment:16 in reply to:  15 Changed 6 months ago by gk

Keywords: TorBrowserTeam201907 added; TorBrowserTeam201907R removed
Status: needs_reviewneeds_revision

Replying to acat:

Thanks. Addressed comments here: https://github.com/acatarineu/torbutton/commit/30577+1

Looks good. I think one final tweak we want to do is not counting down if the user just clicks the link. We only count down if they click the "x" or do a restart.

comment:17 Changed 6 months ago by acat

Status: needs_revisionneeds_review

comment:18 Changed 6 months ago by gk

Keywords: TorBrowserTeam201907R added; TorBrowserTeam201907 removed
Resolution: fixed
Status: needs_reviewclosed

Thanks! We are done here. I merged the branch to torbutton's master (commit 1f05efdb50291d26e7e52d07f3bddabf86ee7796) and updated the translations so our next localized nightly builds are not busted (commit fc5f85c225f7518b078ca20457468e38a78430ad). And I bumped the Torbutton commit we use in the tor-browser repo submodule so we have the changes available on mobile, too. (see tor-browser-60.7.0esr-9.0-1 (commit c8dce5f0a165026ecacec69132b568876916ddc1))

Note: See TracTickets for help on using tickets.