Opened 5 months ago

Closed 3 months ago

Last modified 3 months ago

#30585 closed defect (fixed)

Provide standalone clang 8 project usable across all platforms

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, ff68-esr, TorBrowserTeam201907R, GeorgKoppen201907, tbb-9.0-must-nightly
Cc: tom, boklm, ahf Actual Points:
Parent ID: #28716 Points:
Reviewer: Sponsor: Sponsor44-can

Description

We plan to ship to clang 8 where a clang is needed in Firefox 68. We should create a separate project for it and retire the llvm one we have later on as the consensus seems to be to use "clang" instead of "llvm". This ticket is motivated as well by comment:43:ticket:28716.

Child Tickets

Change History (9)

comment:1 Changed 5 months ago by gk

Keywords: TorBrowserTeam201905R added; TorBrowserTeam201905 removed
Status: newneeds_review

comment:2 Changed 5 months ago by gk

Keywords: TorBrowserTeam201906R added; TorBrowserTeam201905R removed

Moving reviews over to June.

comment:3 Changed 4 months ago by gk

Keywords: GeorgKoppen201906 added; GeorgKoppen201905 removed

Moving my tickets to June

comment:4 Changed 4 months ago by gk

Keywords: TorBrowserTeam201907R added; TorBrowserTeam201906R removed

No reviews in June 2019 anymore, moving them.

comment:5 Changed 4 months ago by gk

Keywords: GeorgKoppen201907 added; GeorgKoppen201906 removed

Moving my tickets to July.

comment:6 Changed 3 months ago by gk

Keywords: tbb-9.0-must-nightly added

Starting with 9.0 keywords

comment:7 in reply to:  1 Changed 3 months ago by boklm

Replying to gk:

bug_30585 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_30585&id=6af8cc6de4010ff0011a55dcefb4927e9e389872) in my tor-browser-build repo has a patch for review.

This patch looks good to me.

In branch bug_30585 I added some minor improvements in fixup patches:

I squashed those two fixup commits in branch bug_30585_v2:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_30585_v2&id=4c2b3a98e04605ce7fcbd1c2c7c4864c6a5125a2

If you agree with those changes, I think it is ready to merge.

comment:8 Changed 3 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Merged to master as 7b6444dd34d7a9e32d619c194e078464529fd5c1. I was a bit worried about creating yet another container-image by just using git for applying patch in the clang project. However, I think that's fine as it is a temporary measure only anyway as all the LLVM patches landed upstream (dunno either why patch is working for Mozilla but not for us, weird).

comment:9 Changed 3 months ago by pili

Sponsor: Sponsor44-can

Adding Sponsor 44 to ESR68 tickets

Note: See TracTickets for help on using tickets.