Fix argument passing in docs/republish

[teor]

shellcheck complains of quoting issues with $*.

[teor]

This ticket can be sponsor 31, because working stem tests help us refactor tor.

I put the changes in a separate commit in my #28170 branch.

[atagar]

Thanks teor, I merged this with your other changes. Out of curiosity why did you feel a need to adjust the republish script? As far as I'm aware it is only used for stem's staticiforme.torproject.org hosting.

[atagar]

Actually, on reflection I don't think republish is even used for that. Iirc I wrote that long ago but have since transitioned to a cron job with a local republication script.

I might simply drop this and the associated script but first I need to check - how did this get on your radar?

[teor]

Replying to atagar:

Actually, on reflection I don't think republish is even used for that. Iirc I wrote that long ago but have since transitioned to a cron job with a local republication script.

I might simply drop this and the associated script but first I need to check - how did this get on your radar?

We use shellcheck as a standard part of tor's CI and chutney's CI. So when I rewrote stem's Travis CI, I added a shellcheck step.

If you delete this script, that's fine with me. I think it's the last shell script, so I'll also remove the shellcheck step from Stem's CI.

[atagar]

​Republication script removed. Feel free to reopen if ya spot anything else.