Opened 8 weeks ago

Last modified 7 weeks ago

#30596 needs_revision defect

stem tests expect platform.linux_distribution, which does not exist in python 3.8

Reported by: teor Owned by: atagar
Priority: Medium Milestone:
Component: Core Tor/Stem Version:
Severity: Normal Keywords: ci, travis
Cc: teor Actual Points:
Parent ID: #28170 Points:
Reviewer: Sponsor:

Description

  python version...                          3.8.0a3+
  operating system...                        failed
module 'platform' has no attribute 'linux_distribution'
The command "./run_tests.py --unit" exited with 1.

https://travis-ci.org/teor2345/stem/jobs/536613179#L1529

Child Tickets

Change History (6)

comment:1 Changed 8 weeks ago by Guinness

It looks like the only way to replace the platform.linux_distribution method (and advised by python (see here) is to use the distro package.
If this is okay for you, I can handle this one and attach the patch here (or a link to the commit on my clone of stem).

comment:2 Changed 8 weeks ago by atagar

Thanks Guinness, sounds good! Patch welcome. If something comes up or you'd care for me to give a crack at this I'll probably get to this over the weekend.

comment:4 Changed 8 weeks ago by teor

All the CI failures are unrelated controller hangs. We're working on them in #29437 and children.

comment:5 Changed 8 weeks ago by atagar

Thanks Guinness! Commented on your PR...

Hi Gu1nness, thank you for your pull request! Our linux_distribution() call is only used for display purposes. I'd prefer if test/task.py simply omits that bit of information when linux_distribution() is unavailable rather than add a new dependency.

comment:6 Changed 7 weeks ago by teor

Status: newneeds_revision
Note: See TracTickets for help on using tickets.