Blurry Tor Browser icon on macOS app switcher

Hello,

Tor Browser's icon is blurred (not enough resolution) in macOS app switcher (⌘+Tab). I think it's most noticeable on Retina displays.

Trac:
Username: vjur

added TorBrowserTeam201906R component::applications/tor browser owner::pospeselr priority::medium reporter::vjur resolution::fixed severity::trivial status::closed tbb-8.5-issues type::defect ux-team labels

Trac:
Username: vjur

macOS app wsitcher with blurred icon

Trac:
Username: vjur

Trac:
Keywords: macos, icon, tor browser deleted, ux-team, tbb-8.5-issues added
Cc: N/A to antonela

Replying to gk:

Seems like the png2icns tool used by my icon generation script doesn't actually output all the requested sizes. I asked antonela to update the source icns to include the padding needed to fit in with other circular macos icons and we'll just put it over the existing firefox.icns in the branding dir.

Trac:
Status: new to assigned
Owner: tbb-team to pospeselr

Trac:
Tor_Browser.icns

Trac:
Tor_Browser_Nigthly.icns

Trac:
Tor_Browser_Alpha.icns

Thanks pospeselr for taking this! Back in #25702 (moved) work, I exported this .icns. Let me know if anything else is needed.

https://trac.torproject.org/projects/tor/attachment/ticket/30631/Tor%20Browser.icns https://trac.torproject.org/projects/tor/attachment/ticket/30631/Tor%20Browser%20Nigthly.icns https://trac.torproject.org/projects/tor/attachment/ticket/30631/Tor%20Browser%20Alpha.icns

Updated the icns files in this branch:

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_30631&id=defe73e8c1969c02f137e8b474d85a66b9605427

macOS build: https://people.torproject.org/~richard/builds/30631-TorBrowser-tbb-nightly-osx64_en-US.dmg

Verified in a macOS vm, if you jack up the icon size to 512x512 it's crisp and full res wheras if you do the same with the latest release build from torproject.org the icon is pixelated and bad.

Trac:
Status: assigned to needs_review

Trac:
Keywords: N/A deleted, TorBrowserTeam201906R added

Turns out one can actually see the issue in inkscape which I missed back then, sorry my bad. Either way, I merged the changes to tor-browser-60.7.0esr-9.0-1 (commit defe73e8c1969c02f137e8b474d85a66b9605427) and cherry-picked them to tor-browser-60.7.0esr-8.5-1 (commit 33913360097ee1c5c806f9a7124f69d3cfd58ded). We can squash the commit together with the one for #25702 (moved) during esr68 rebasing (no need to do another round trip to squash it right now)

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-browser#30631 (closed)