Opened 7 months ago

Closed 6 months ago

#30631 closed defect (fixed)

Blurry Tor Browser icon on macOS app switcher

Reported by: vjur Owned by: pospeselr
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Trivial Keywords: ux-team, tbb-8.5-issues, TorBrowserTeam201906R
Cc: antonela Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Hello,

Tor Browser's icon is blurred (not enough resolution) in macOS app switcher (⌘+Tab). I think it's most noticeable on Retina displays.

Child Tickets

Attachments (4)

tor-browser-icon-blur-macos.png (271.6 KB) - added by vjur 7 months ago.
macOS app wsitcher with blurred icon
Tor Browser.icns (731.8 KB) - added by antonela 7 months ago.
Tor Browser Nigthly.icns (1.3 MB) - added by antonela 7 months ago.
Tor Browser Alpha.icns (804.6 KB) - added by antonela 7 months ago.

Change History (11)

Changed 7 months ago by vjur

macOS app wsitcher with blurred icon

comment:1 Changed 7 months ago by gk

Cc: antonela added
Keywords: ux-team tbb-8.5-issues added; icon tor browser macos removed

comment:2 in reply to:  1 Changed 7 months ago by pospeselr

Owner: changed from tbb-team to pospeselr
Status: newassigned

Replying to gk:

Seems like the png2icns tool used by my icon generation script doesn't actually output all the requested sizes. I asked antonela to update the source icns to include the padding needed to fit in with other circular macos icons and we'll just put it over the existing firefox.icns in the branding dir.

Changed 7 months ago by antonela

Attachment: Tor Browser.icns added

Changed 7 months ago by antonela

Attachment: Tor Browser Nigthly.icns added

Changed 7 months ago by antonela

Attachment: Tor Browser Alpha.icns added

comment:4 Changed 6 months ago by pospeselr

Updated the icns files in this branch:

tor-browser: https://gitweb.torproject.org/user/richard/tor-browser.git/commit/?h=bug_30631&id=defe73e8c1969c02f137e8b474d85a66b9605427

macOS build: https://people.torproject.org/~richard/builds/30631-TorBrowser-tbb-nightly-osx64_en-US.dmg

Verified in a macOS vm, if you jack up the icon size to 512x512 it's crisp and full res wheras if you do the same with the latest release build from torproject.org the icon is pixelated and bad.

Last edited 6 months ago by pospeselr (previous) (diff)

comment:5 Changed 6 months ago by pospeselr

Status: assignedneeds_review

comment:6 Changed 6 months ago by pospeselr

Keywords: TorBrowserTeam201906R added

comment:7 Changed 6 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Turns out one can actually see the issue in inkscape which I missed back then, sorry my bad. Either way, I merged the changes to tor-browser-60.7.0esr-9.0-1 (commit defe73e8c1969c02f137e8b474d85a66b9605427) and cherry-picked them to tor-browser-60.7.0esr-8.5-1 (commit 33913360097ee1c5c806f9a7124f69d3cfd58ded). We can squash the commit together with the one for #25702 during esr68 rebasing (no need to do another round trip to squash it right now)

Note: See TracTickets for help on using tickets.