Opened 7 weeks ago

Closed 7 weeks ago

#30635 closed enhancement (fixed)

Sync mobile default bridges list with desktop one

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, TorBrowserTeam201905, GeorgKoppen201905R, tbb-parity
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We should ship the same default bridges on mobile and desktop. That helps keeping track of bridges we need to monitor and helps debugging problems with default bridges in general.

Child Tickets

Change History (8)

comment:1 Changed 7 weeks ago by sysrqb

Status: newneeds_review

I copied the current bridges (including snowflake).

Repo: https://github.com/sysrqb/tor-android-service/
Branch: bug30635_00

comment:2 Changed 7 weeks ago by sysrqb

Less important, but I pushed a branch that adds a comment at the top of bridge_prefs.js reminding us about keeping these bridges synchronized with the Android list.

It's in my tor-browser-build repo, branch bug30635_00.

comment:3 Changed 7 weeks ago by gk

Status: needs_reviewneeds_revision

Let's omit snowflake for now. We post-process the bridges list on desktop in a way that only the bridges get bundles that are actually available on the platform/in the series, which is e.g. omitting snowflake when it is not supported. We should not add it unconditionally now to mobile.

comment:4 Changed 7 weeks ago by sysrqb

Status: needs_revisionneeds_review

We don't provide a UI on Android for snowflake, so selecting it shouldn't be possible (and tor-android-service doesn't know how to handle it), but I pushed a new branch without the snowflake line: bug30635_01.

comment:5 in reply to:  4 ; Changed 7 weeks ago by gk

Status: needs_reviewneeds_revision

Replying to sysrqb:

We don't provide a UI on Android for snowflake, so selecting it shouldn't be possible (and tor-android-service doesn't know how to handle it), but I pushed a new branch without the snowflake line: bug30635_01.

Yes, but I want to push the fix directly to stable and we should therefore keep the changes to the minimum necessary. For instance, we need to keep the meek line as it is in mobile right now as the underlying code is expecting meek_lite or does not use meek at all otherwise if meek-azure is selected (see: TOPL's TorConfigBuilder.java for why that's the case).

Last edited 7 weeks ago by gk (previous) (diff)

comment:6 in reply to:  5 Changed 7 weeks ago by sysrqb

Keywords: GeorgKoppen201905R added; GeorgKoppen201905 removed
Status: needs_revisionneeds_review

Replying to gk:

Replying to sysrqb:

We don't provide a UI on Android for snowflake, so selecting it shouldn't be possible (and tor-android-service doesn't know how to handle it), but I pushed a new branch without the snowflake line: bug30635_01.

Yes, but I want to push the fix directly to stable and we should therefore keep the changes to the minimum necessary. For instance, we need to keep the meek line as it is in mobile right now as the underlying code is expecting meek_lite or does not use meek at all otherwise if meek-azure is selected (see: TOPL's TorConfigBuilder.java for why that's the case).

Right, sorry for not being more careful about changing the meek line. I pushed branch bug30635_02 with meek_lite (and now the line doesn't change in this patch).

comment:7 Changed 7 weeks ago by cypherpunks

GeorgKoppen201905R :)

comment:8 Changed 7 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good now. I merged your patch to tor-android-service's master (commit d9b049c8cee225b4e7bb6f0191093f543d0f9f65) and bumped the commit on the respective tor-browser-build branches (commit 68bfb37ac2643945268e124942540d40bb014869 on master and commit 8fe019d3f4cb27d549727b6754e4ffb38fafbe1f on maint-8.5).

Note: See TracTickets for help on using tickets.