Opened 17 months ago

Closed 7 months ago

#30638 closed task (fixed)

Test banning ed25519 keys in the approved-routers file on moria1

Reported by: teor Owned by: dgoulet
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-dirauth, 042-deferred-20190918 043-should, network-health
Cc: neel, arma Actual Points:
Parent ID: Points: 1
Reviewer: arma Sponsor:


After #22029 merges to master, we should test that we can ban ed25519 keys on the public tor network.

We should email arma after the merge, and close this ticket once he confirms that the feature works.

Child Tickets

Change History (10)

comment:1 Changed 14 months ago by nickm

Keywords: 042-deferred-20190918 added
Milestone: Tor: 0.4.2.x-finalTor: 0.4.3.x-final

Defer numerous 0.4.2 tickets to 0.4.3.

comment:2 Changed 10 months ago by nickm

Keywords: 042-should added
Parent ID: #22029

comment:3 Changed 10 months ago by teor

Keywords: 043-should added; 042-should removed
Owner: set to arma
Status: newassigned

This code was merged in 0.4.3, so it's 043-should.

I think arma is the most logical person to do this test, because he often runs master on moria1.
(Although any other authority operator could also run master and try it.

comment:4 Changed 9 months ago by arma

If somebody gives me an approved-routers line to add, I can add it. And then you can observe the resulting votes and decide whether it worked the way you want?

comment:5 Changed 9 months ago by teor

Owner: arma deleted

#30642 adds an ed25519_identity file to relay data directories. It's waiting for review.

So here's how we can move forward:

  • a relay operator runs that branch on their relay,
  • turns that file into a reject line,
  • sends it to arma, and
  • checks that moria1 excludes their relay.

I'll un-assign this ticket, so we assign it to a network team staff member to make this happen.

comment:6 Changed 9 months ago by teor

Reviewer: arma
Status: assignednew

comment:7 Changed 9 months ago by gk

Keywords: network-health added

comment:8 Changed 9 months ago by dgoulet

Owner: set to dgoulet
Status: newaccepted

I will take over this. We'll provide to moria1 a legit reject by ed25519 id and see what happens :).

comment:9 Changed 7 months ago by dgoulet

Milestone: Tor: 0.4.3.x-finalTor: unspecified

This depends on moria1 operator, arma, and arma's schedule is quantum so we shouldn't block 043 on this.

comment:10 Changed 7 months ago by teor

Resolution: fixed
Status: acceptedclosed

We merged this code in 0.4.3, and there are unit tests for it.
Maybe we should have asked for a tor "make check" integration test as well.

Let's just close this ticket?

Note: See TracTickets for help on using tickets.