Add our own base-64 encoded ed25519 public key in dirserv_add_own_fingerprint()

We need to add our own ed25519 identity when we add our own RSA fingerprint.

We should have separate static functions for RSA and ed25529, and call them from dirserv_add_own_fingerprint().

changed milestone to %Tor: 0.4.2.x-final

Trac:
Parent Ticket: #22029 (moved)

added component::core tor/tor milestone::Tor: 0.4.2.x-final owner::neel parent::22029 priority::medium resolution::fixed severity::normal status::closed tor-ed25519 type::enhancement labels

Trac:
Owner: N/A to neel
Status: new to assigned

PR: https://github.com/torproject/tor/pull/970 with commit f1a236a.

Trac:
Status: assigned to needs_review

Thanks for this change!

This code is independent of the rest of #22029 (moved), so please make a separate branch for it. Then someone else can review that branch in this ticket.

The code needs these changes:

• add_rsa_fingerprint_to_dir() can fail and return -1, if it does, dirserv_add_own_fingerprint() should return -1
• add_ed25519_to_dir() can fail and return -1, if it does, dirserv_add_own_fingerprint() should return -1

You can do the check and the warning like this: https://github.com/torproject/tor/pull/970/commits/f1a236a8360ce0af2ad1bece4e89960463e57e3f#diff-c535b81e06d7fed27d5d3cdaabf1c4b8R160 But please use a different log message for each warning.

Trac:
Status: needs_review to needs_revision
Milestone: Tor: unspecified to Tor: 0.4.2.x-final
Keywords: N/A deleted, tor-ed25519 added

neel created this pull request for this ticket: https://github.com/torproject/tor/pull/1125

Replying to teor:

The code needs these changes:

• add_rsa_fingerprint_to_dir() can fail and return -1, if it does, dirserv_add_own_fingerprint() should return -1
• add_ed25519_to_dir() can fail and return -1, if it does, dirserv_add_own_fingerprint() should return -1

You can do the check and the warning like this: https://github.com/torproject/tor/pull/970/commits/f1a236a8360ce0af2ad1bece4e89960463e57e3f#diff-c535b81e06d7fed27d5d3cdaabf1c4b8R160 But please use a different log message for each warning.

The code should also have unit tests.

Please remove all the #22029 (moved) commits from the branch: this branch should start with "Add our own base-64 encoded ed25519 public key in dirserv_add_own_fingerprint()" and any fix ups and tests.

Here's a problem: add_ed25519_to_dir() was introduced in #22029 (moved) and the commits before "Add our own base-64 encoded ed25519 public key in dirserv_add_own_fingerprint()".

This commit adds add_ed25519_to_dir():

Allow ed25519 keys to be banned in approved-routers commit 7267177b89e7db4f9482e33614f813564c198ec1

I have added a test, but it uses the same branch with the #22029 (moved) commits.

The test is in commit: 84d95f3.

I am unable to do this PR separate from the #22029 (moved) commits because #22029 (moved) introduces the ed25519 key handling.

Ok, let's put all the commits for this ticket and #22029 (moved) on https://github.com/torproject/tor/pull/970 then. It has the pull request review comments, and all the code that this ticket needs.

If I want to split up the branch for merging, I'll do that after I review it.

Trac:
Status: needs_revision to closed
Resolution: N/A to fixed

closed

moved to tpo/core/tor#30644 (closed)