Opened 4 months ago

Closed 4 months ago

#30646 closed defect (fixed)

HSFETCH always returning 512 Bad argument

Reported by: csucu Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version: Tor: 0.4.1.1-alpha
Severity: Normal Keywords: control-port hsfetch, regression, 041-regression, 041-must, dgoulet-merge
Cc: nickm Actual Points: 0
Parent ID: Points: 0.1
Reviewer: ahf Sponsor:

Description

Doing a "HSFETCH" on a v2 or v3 service always seems to return "512 Bad arguments to HSFETCH: Empty body"

i.e

telnet localhost 9055
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
AUTHENTICATE
250 OK
HSFETCH facebookcorewwwi      
512 Bad arguments to HSFETCH: Empty body

Works fine for version 0.4.0.5

Child Tickets

Change History (8)

comment:1 Changed 4 months ago by dgoulet

Cc: nickm added
Keywords: regression added
Milestone: Tor: 0.4.1.x-final
Points: 0.1

The .want_cmddata = true, is set for the HSFETCH command but it shouldn't...

This was introduced by commit d8b3ec865de2738144bd6bbf9f6355662e64eb25 released in 0.4.1.1.

comment:2 Changed 4 months ago by nickm

Keywords: 041-regression added
Owner: set to nickm
Status: newaccepted

comment:3 Changed 4 months ago by nickm

Keywords: 041-must added

comment:4 Changed 4 months ago by teor

See also #30580, where the same refactor broke POSTDESCRIPTOR.

What can we do to make sure we haven't broken anything else?

comment:5 Changed 4 months ago by nickm

Actual Points: 0
Status: acceptedneeds_review

Fix in branch 30646; PR at https://github.com/torproject/tor/pull/1055

I added #30676 to look at our controller test coverage.

comment:6 Changed 4 months ago by ahf

Status: needs_reviewmerge_ready

Looks good.

comment:7 Changed 4 months ago by nickm

Keywords: dgoulet-merge added

comment:8 Changed 4 months ago by dgoulet

Resolution: fixed
Reviewer: ahf
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.