Opened 3 weeks ago

Closed 3 weeks ago

#30653 closed enhancement (fixed)

Add stem CI for --target ONLINE

Reported by: teor Owned by: teor
Priority: Medium Milestone:
Component: Core Tor/Stem Version:
Severity: Normal Keywords: ci, travis
Cc: teor Actual Points: 0.2
Parent ID: #28170 Points: 0.2
Reviewer: Sponsor: Sponsor31-can

Description

From https://trac.torproject.org/projects/tor/ticket/28170#comment:14

    Run 'run_tests.py --all' with python 2.6.
    Run 'run_tests.py --all' with python 2.7.
    Run 'run_tests.py --all' with python 3.x.
    Run 'run_tests.py --all --target ONLINE' with python 2.7. 

Here's what I need to do:

  • check to see if Travis supports python 2.6, and add a job with 2.6
  • make the 2.7 job --target ONLINE
    • assuming that ONLINE is a superset of offline
  • make the latest python 3.x job --target ONLINE
    • assuming that ONLINE is a superset of offline

I'm modifying existing jobs to save build time: we could create separate jobs for ONLINE, but that would add ~5 minutes to every CI run.

Child Tickets

Change History (5)

comment:1 Changed 3 weeks ago by teor

Summary: Add stemAdd stem CI for python 2.6 and --target ONLINE

comment:2 Changed 3 weeks ago by atagar

Summary: Add stem CI for python 2.6 and --target ONLINEAdd stem CI for --target ONLINE

Thanks teor! On reflection lets drop the python 2.6 check. Python 2.x is getting deprecated at the end of the year so it would probably not make a lot of sense to chase down those regressions. Adjusting the ticket title to reflect that.


To both speed up Tor's CI and cut down on false positives I just adjusted stem so you can now run...

./run_tests.py --integ --test control.controller --test control.base_controller --test process

This will limit stem to only run the tests that the network team has cause to care about. If any of the other tests break then that's a regression on my end, not yours. ;P


To be clear I'm suggesting two CIs:

  1. Tests tor/stem interoperability. This is the only thing the network team has cause to care about. For this I'd suggest running python 3.x with...

run_tests.py --integ --test control.controller --test control.base_controller --test process

  1. Stem's own CI testing. For this I'd love to exercise multiple python versions (2.7, 3.x, pypy?) and the online target. These failures only need to notify me.

That said, happy to defer to whatever you think teor. :)

comment:3 in reply to:  2 Changed 3 weeks ago by teor

Actual Points: 0.1
Points: 0.1
Status: assignedneeds_review

Replying to atagar:

To be clear I'm suggesting two CIs:

  1. Tests tor/stem interoperability. This is the only thing the network team has cause to care about. For this I'd suggest running python 3.x with...

run_tests.py --integ --test control.controller --test control.base_controller --test process

I opened #30694 for this change in Tor.

  1. Stem's own CI testing. For this I'd love to exercise multiple python versions (2.7, 3.x, pypy?) and the online target. These failures only need to notify me.

I made this change in the #28170 branch. Notifications are #30652.

comment:4 Changed 3 weeks ago by teor

Actual Points: 0.10.2
Points: 0.10.2
Sponsor: Sponsor31-can

comment:5 Changed 3 weeks ago by atagar

Resolution: fixed
Status: needs_reviewclosed

Thanks teor, merged.

Note: See TracTickets for help on using tickets.