Opened 3 months ago

Closed 2 months ago

#30691 closed enhancement (fixed)

Refactor decoding outside the if expression in dirserv_load_fingerprint_file()

Reported by: teor Owned by: neel
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt
Cc: neel Actual Points:
Parent ID: #22029 Points:
Reviewer: teor Sponsor:

Description

There have already been two bugs in this code, so we should refactor it:
https://github.com/torproject/tor/pull/970#pullrequestreview-242268332

Child Tickets

Change History (3)

comment:1 Changed 2 months ago by neel

Owner: set to neel
Status: newassigned

comment:2 Changed 2 months ago by neel

Status: assignedneeds_review

comment:3 Changed 2 months ago by teor

Resolution: fixed
Reviewer: teor
Status: needs_reviewclosed

I'm going to review this code in #22029.

Note: See TracTickets for help on using tickets.