Opened 4 months ago

Closed 3 months ago

#30692 closed defect (fixed)

Write better unit tests for dirserv_load_fingerprint_file()

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: neel Actual Points:
Parent ID: #22029 Points:
Reviewer: Sponsor:

Description

The existing tests don't catch format string bugs, because they only run on expected inputs:
https://github.com/torproject/tor/pull/970#pullrequestreview-242268332

Child Tickets

Change History (3)

comment:2 Changed 3 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.4.2.x-final
Status: newneeds_review

comment:3 Changed 3 months ago by teor

Resolution: fixed
Status: needs_reviewclosed

We'll deal with this in the parent ticket.

Note: See TracTickets for help on using tickets.