Opened 3 weeks ago

Closed 2 weeks ago

#30713 closed defect (fixed)

Disable or allow_fail test_rebind.py in macOS Travis

Reported by: catalyst Owned by: teor
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.3.5.1-alpha
Severity: Normal Keywords: tor-ci, rare?, 035-backport, 040-backport, tor-ci-fail-sometimes
Cc: Actual Points: 0.2
Parent ID: #28229 Points: 0.2
Reviewer: catalyst Sponsor: Sponsor31-can

Description

test_rebind.py is having spurious failures often on macOS. We should either allow_fail the macOS builds, or disable test_rebind.py.

Child Tickets

Change History (7)

comment:1 Changed 3 weeks ago by teor

Owner: set to teor
Status: newassigned

We decided to disable it on macOS.

comment:2 Changed 3 weeks ago by teor

03:25 nickm: I'd just add an environment variable for disabling test_rebind.py, and add it to the relevant entries in the travis file

comment:3 Changed 2 weeks ago by teor

Actual Points: 0.2
Points: 0.2
Status: assignedneeds_review

See my pull requests:

We should backport this as soon as it passes on master, because it's a CI fix, that only skips a test on one platform.

comment:4 Changed 2 weeks ago by dgoulet

Reviewer: catalyst

comment:5 in reply to:  3 Changed 2 weeks ago by catalyst

Status: needs_reviewmerge_ready

Replying to teor:

See my pull requests:

We should backport this as soon as it passes on master, because it's a CI fix, that only skips a test on one platform.

Thanks; looks good! I manually spot-checked on a macOS machine. The build failure on https://travis-ci.org/torproject/tor/jobs/543674391 seems to be the known test-stem timeout.

comment:6 Changed 2 weeks ago by nickm

Keywords: 041-should removed
Milestone: Tor: 0.4.1.x-finalTor: 0.3.5.x-final

Merged to 0.4.0 and forward. Marking for 0.3.5 backport.

comment:7 Changed 2 weeks ago by teor

Resolution: fixed
Status: merge_readyclosed

Backported to 0.3.5.

Note: See TracTickets for help on using tickets.