Opened 16 months ago

Closed 8 months ago

#30727 closed defect (fixed)

Make sbws vote for all measured relays, even if they are not Running / not in the consensus

Reported by: teor Owned by: juga
Priority: Very High Milestone: sbws: 1.1.x-final
Component: Core Tor/sbws Version: sbws: 1.1.0
Severity: Critical Keywords: must-keep-3-torflow-blocker, sbws-majority-blocker, sbws-roadmap
Cc: juga Actual Points:
Parent ID: #33121 Points:
Reviewer: ahf Sponsor:

Description

I think the answer is probably "yes, but other tickets are more important right now".

Child Tickets

Change History (14)

comment:1 Changed 16 months ago by teor

Milestone: sbws: unspecifiedsbws: 1.1.x-final
Priority: HighVery High
Severity: MajorCritical
Summary: Should sbws vote for relays that aren't Running?Make sbws vote for all measured relays, even if they are not Running
Version: sbws: unspecifiedsbws: 1.1.0

Until we do this fix, we need to keep at least 3 torflow instances in the network.

For more details, see:
https://trac.torproject.org/projects/tor/ticket/29710#comment:16

We also need to do this fix because authorities and clients can have different views of the Running relays.

comment:2 Changed 16 months ago by teor

Keywords: must-keep-3-torflow-blocker sbws-majority-blocker added

comment:3 Changed 15 months ago by juga

I found more relevant information in https://trac.torproject.org/projects/tor/ticket/29710?replyto=13#comment:

sbws only reports bandwidths for Running relays, but torflow reports bandwidths for all relays it has recently measured.

So, is torflow reporting bandwidth for all the relays seen in the last 5 days even if they were not in the consensus?. What about the relays for which there's no descriptors?, just use the last descriptor seen?.

comment:4 in reply to:  3 Changed 15 months ago by teor

Summary: Make sbws vote for all measured relays, even if they are not RunningMake sbws vote for all measured relays, even if they are not Running / not in the consensus

Replying to juga:

I found more relevant information in https://trac.torproject.org/projects/tor/ticket/29710?replyto=13#comment:

sbws only reports bandwidths for Running relays, but torflow reports bandwidths for all relays it has recently measured.

So, is torflow reporting bandwidth for all the relays seen in the last 5 days even if they were not in the consensus?

Yes.

What about the relays for which there's no descriptors?, just use the last descriptor seen?.

Why is sbws missing the descriptors for some relays?
The authorities and directory mirrors should have them?
See bug #30733.

But yes, if we can't get the descriptor in the consensus (or if the relay is not in the consensus), just use the most recent descriptor data we have.

comment:5 Changed 9 months ago by teor

Owner: set to juga
Status: newassigned

Juga says they have some unpublished work on this ticket.

comment:6 Changed 8 months ago by juga

Status: assignedneeds_review

comment:8 Changed 8 months ago by ahf

Reviewer: ahf

comment:9 Changed 8 months ago by gaba

Keywords: sbws-roadmap added

comment:10 Changed 8 months ago by ahf

Status: needs_reviewneeds_revision

Added a few minor nitpicks and also I think there is a missing return statement, but all-in-all it looks good.

comment:11 Changed 8 months ago by juga

Status: needs_revisionneeds_review

Thanks, i think i addressed what you commented.

comment:12 Changed 8 months ago by ahf

Status: needs_reviewmerge_ready

Looks good!

comment:13 Changed 8 months ago by gaba

Parent ID: #29710#33121

The goal is to deploy sbws in all bw authorities. We need to fix critical bugs to do this.

comment:14 Changed 8 months ago by juga

Resolution: fixed
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.