Opened 3 months ago

Last modified 2 months ago

#30727 new defect

Make sbws vote for all measured relays, even if they are not Running / not in the consensus

Reported by: teor Owned by:
Priority: Very High Milestone: sbws: 1.1.x-final
Component: Core Tor/sbws Version: sbws: 1.1.0
Severity: Critical Keywords: must-keep-3-torflow-blocker, sbws-majority-blocker
Cc: juga Actual Points:
Parent ID: #29710 Points:
Reviewer: Sponsor:

Description

I think the answer is probably "yes, but other tickets are more important right now".

Child Tickets

Change History (4)

comment:1 Changed 3 months ago by teor

Milestone: sbws: unspecifiedsbws: 1.1.x-final
Priority: HighVery High
Severity: MajorCritical
Summary: Should sbws vote for relays that aren't Running?Make sbws vote for all measured relays, even if they are not Running
Version: sbws: unspecifiedsbws: 1.1.0

Until we do this fix, we need to keep at least 3 torflow instances in the network.

For more details, see:
https://trac.torproject.org/projects/tor/ticket/29710#comment:16

We also need to do this fix because authorities and clients can have different views of the Running relays.

comment:2 Changed 3 months ago by teor

Keywords: must-keep-3-torflow-blocker sbws-majority-blocker added

comment:3 Changed 2 months ago by juga

I found more relevant information in https://trac.torproject.org/projects/tor/ticket/29710?replyto=13#comment:

sbws only reports bandwidths for Running relays, but torflow reports bandwidths for all relays it has recently measured.

So, is torflow reporting bandwidth for all the relays seen in the last 5 days even if they were not in the consensus?. What about the relays for which there's no descriptors?, just use the last descriptor seen?.

comment:4 in reply to:  3 Changed 2 months ago by teor

Summary: Make sbws vote for all measured relays, even if they are not RunningMake sbws vote for all measured relays, even if they are not Running / not in the consensus

Replying to juga:

I found more relevant information in https://trac.torproject.org/projects/tor/ticket/29710?replyto=13#comment:

sbws only reports bandwidths for Running relays, but torflow reports bandwidths for all relays it has recently measured.

So, is torflow reporting bandwidth for all the relays seen in the last 5 days even if they were not in the consensus?

Yes.

What about the relays for which there's no descriptors?, just use the last descriptor seen?.

Why is sbws missing the descriptors for some relays?
The authorities and directory mirrors should have them?
See bug #30733.

But yes, if we can't get the descriptor in the consensus (or if the relay is not in the consensus), just use the most recent descriptor data we have.

Note: See TracTickets for help on using tickets.