#30734 closed defect (fixed)
Add nasm project for building Firefox 68 ESR
| Reported by: | gk | Owned by: | tbb-team |
|---|---|---|---|
| Priority: | Medium | Milestone: | |
| Component: | Applications/Tor Browser | Version: | |
| Severity: | Normal | Keywords: | tbb-rbm, ff68-esr, GeorgKoppen201907, TorBrowserTeam201908R, tbb-9.0-must-nightly |
| Cc: | boklm | Actual Points: | |
| Parent ID: | #30320 | Points: | |
| Reviewer: | Sponsor: | Sponsor44-can |
Description
nasm >= 2.13 is a build requirement for Firefox 68 ESR. We should add a respective project in tor-browser-build.
Child Tickets
Change History (10)
comment:1 Changed 6 months ago by
comment:2 Changed 6 months ago by
It's June. And it's a yasm replacement and not addition of some nsam.
comment:3 Changed 6 months ago by
| Summary: | Add nsam project for building Firefox 68 ESR → Add nasm project for building Firefox 68 ESR |
|---|
comment:4 Changed 6 months ago by
| Keywords: | TorBrowserTeam201906 added; TorBrowserTeam201905 removed |
|---|
Moving tickets to June
comment:5 Changed 6 months ago by
| Keywords: | GeorgKoppen201906 added; GeorgKoppen201905 removed |
|---|
Moving my tickets to June
comment:6 Changed 5 months ago by
| Keywords: | GeorgKoppen201907 added; GeorgKoppen201906 removed |
|---|
Moving my tickets to July.
comment:7 Changed 5 months ago by
| Keywords: | TorBrowserTeam201907 added; TorBrowserTeam201906 removed |
|---|
Moving tickets to July
comment:9 Changed 4 months ago by
| Keywords: | TorBrowserTeam201908R added; TorBrowserTeam201907 removed |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
The commit from branch gk/linux_esr68_v7 looks good to me. I cherry picked it to master as commit 460d5ef80d2bb7ebf808574d21ec7fe43dd9dd01.
Note: See
TracTickets for help on using
tickets.
bug_30734(https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_30734&id=f22fb1168ee393fb16cee69391607cbf7623c7df) has a PoC that seems to work.