Opened 3 months ago

Closed 3 weeks ago

#30736 closed defect (fixed)

Make sure we have Yasm >= 1.2.0 available on Linux 64bit

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, ff68-esr, TorBrowserTeam201908R, tbb-9.0-must-nightly
Cc: boklm Actual Points:
Parent ID: #30321 Points:
Reviewer: Sponsor: Sponsor44-can

Description

Similar to #18831 we now need Yasm >= 1.2.0 available as the 64bit build breaks without it otherwise:

 8:23.07 /usr/bin/yasm -o jccolor-avx2.o -f elf64 -rnasm -pnasm -g dwarf2 -D__x86_64__ -DPIC -DELF -I/var/tmp/build/firefox-8ba4752bc100/media/libjpeg/simd/nasm/ -I/var/tmp/build/firefox-8ba4752bc100/media/libjpeg/simd/x86_64/   /var/tmp/build/firefox-8ba4752bc100/media/libjpeg/simd/x86_64/jccolor-avx2.asm
 8:23.07 media/libjpeg/jccolor-sse2.o
 8:23.09 /var/tmp/build/firefox-8ba4752bc100/media/libjpeg/simd/x86_64/jccolext-avx2.asm:56: error: undefined symbol `jsimd_rgb_ycc_convert_avx2.return' (first use)

and similar errors.

Child Tickets

Change History (10)

comment:1 Changed 3 months ago by cypherpunks

Please, read https://bugzilla.mozilla.org/show_bug.cgi?id=1501796 carefully. It shouldn't ask for yasm on systems, where proper nasm is available.

comment:2 in reply to:  1 ; Changed 3 months ago by gk

Replying to cypherpunks:

Please, read https://bugzilla.mozilla.org/show_bug.cgi?id=1501796 carefully. It shouldn't ask for yasm on systems, where proper nasm is available.

But it does explicitly and fails if none is available:

ERROR: Yasm is required to build with ffvpx, jpeg, libav and vpx, but you do not appear to have Yasm installed.

comment:3 in reply to:  2 Changed 3 months ago by gk

Replying to gk:

Replying to cypherpunks:

Please, read https://bugzilla.mozilla.org/show_bug.cgi?id=1501796 carefully. It shouldn't ask for yasm on systems, where proper nasm is available.

But it does explicitly and fails if none is available:

ERROR: Yasm is required to build with ffvpx, jpeg, libav and vpx, but you do not appear to have Yasm installed.

Oh, and this comes from https://hg.mozilla.org/mozilla-central/rev/2c4de7449db2 which landed after the fix for bug 1501796.

comment:4 Changed 3 months ago by gk

It seems just using wheezy-backports is what Mozilla is doing: https://searchfox.org/mozilla-beta/source/taskcluster/docker/debian-build/Dockerfile#61. I guess that's an option here too.

comment:5 Changed 3 months ago by cypherpunks

Yes. And who knows what they meant then by

OK. I don't get any warnings anymore when only having nasm installed.

comment:6 Changed 6 weeks ago by gk

Keywords: TorBrowserTeam201907 tbb-9.0-must-nightly added

comment:7 Changed 3 weeks ago by boklm

Keywords: TorBrowserTeam201908R added; TorBrowserTeam201907 removed
Status: newneeds_review

There is a patch for review in branch bug_30736:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_30736&id=0a8ab5b289753683cf9a5bfae3bd6e24b463eeb1

This replaces commit 7cc6689388205a04900d4eee49aceb77fb708e52 from branch gk/linux_esr68_v7.

comment:8 Changed 3 weeks ago by gk

Looks good to me.

comment:9 Changed 3 weeks ago by pili

Sponsor: Sponsor44-can

Adding Sponsor 44 to ESR68 tickets

comment:10 Changed 3 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Merged to master (commit 0a8ab5b289753683cf9a5bfae3bd6e24b463eeb1).

Note: See TracTickets for help on using tickets.