Opened 7 weeks ago

Last modified 6 weeks ago

#30743 assigned enhancement

Write a coccinelle script to catch increment/decrement calls inside log_debug().

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


See #30628 for motivation

Child Tickets

Change History (1)

comment:1 Changed 6 weeks ago by nickm

Here's a script that catches one case, and the other 3 cases are easy enough to infer...

expression E;
*log_debug(... , <+... E-- ...+>, ... );

The problem, though, is that a lot of our files don't parse for coccinelle right now, because of our macro madness. We'll need to extend scripts/coccinelle/tor-coccinelle.h till everything works.

Note: See TracTickets for help on using tickets.