Opened 4 months ago

Closed 4 months ago

#30744 closed defect (fixed)

Allow failures in the Travis test-stem job

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.3.5.4-alpha
Severity: Normal Keywords: tor-ci-fail-sometimes, 035-backport, 040-backport, 041-backport
Cc: Actual Points: 0.2
Parent ID: #29437 Points: 0.1
Reviewer: catalyst Sponsor: Sponsor31-can

Description


Child Tickets

Change History (7)

comment:1 Changed 4 months ago by nickm

Keywords: 041-should added

comment:2 Changed 4 months ago by teor

Actual Points: 0.2
Sponsor: Sponsor31-can
Status: assignedneeds_review
Version: Tor: 0.2.4.8-alphaTor: 0.3.5.4-alpha

This can be sponsor 31, because we use test-stem to check refactoring.

See my pull requests:

We can backport this change as soon as it passes on master, because it's a CI-only fix.

comment:3 Changed 4 months ago by dgoulet

Reviewer: catalyst

comment:4 in reply to:  2 ; Changed 4 months ago by catalyst

Status: needs_reviewmerge_ready

Replying to teor:

This can be sponsor 31, because we use test-stem to check refactoring.

See my pull requests:

We can backport this change as soon as it passes on master, because it's a CI-only fix.

Thanks; this looks good! https://travis-ci.org/torproject/tor/builds/543644646 shows an allowed failure. There seem to still be cases where test-stem will time out Travis, causing an error, instead of a failure. I'm not sure if allow_failures will catch it, but maybe we can try to rerun jobs until it does?

comment:5 Changed 4 months ago by nickm

Keywords: 041-should removed
Milestone: Tor: 0.4.1.x-finalTor: 0.3.5.x-final

Merged to 0.4.0 and forward; marking for 0.3.5 backport.

comment:6 in reply to:  4 Changed 4 months ago by teor

Replying to catalyst:

Replying to teor:

This can be sponsor 31, because we use test-stem to check refactoring.

See my pull requests:

We can backport this change as soon as it passes on master, because it's a CI-only fix.

Thanks; this looks good! https://travis-ci.org/torproject/tor/builds/543644646 shows an allowed failure. There seem to still be cases where test-stem will time out Travis, causing an error, instead of a failure. I'm not sure if allow_failures will catch it, but maybe we can try to rerun jobs until it does?

If timelimit isn't terminating stem, then that's a separate bug which we should fix.

comment:7 Changed 4 months ago by teor

Resolution: fixed
Status: merge_readyclosed

Backported to 0.3.5.

Note: See TracTickets for help on using tickets.