Opened 3 months ago

Closed 2 months ago

#30780 closed defect (fixed)

Return a distinct was_router_added_t when formatting annotations fails

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: easy, intro, technical-debt, tor-bridge, dgoulet-merge
Cc: catalyst Actual Points: 0.3
Parent ID: Points: 0.2
Reviewer: nickm Sponsor: Sponsor30-can

Description

There's a note in dirserv_add_multiple_descriptors() that this is bad.

But no-one ever fixed it.

Child Tickets

Change History (9)

comment:1 Changed 3 months ago by teor

Actual Points: 0.2
Keywords: technical-debt added
Points: 0.2
Sponsor: Sponsor30-can
Version: Tor: unspecified

This is a bug introduced by commit b5c8a8ae53c in 0.2.0.8-alpha.

I'll put the fix in a commit in #16564.

comment:2 Changed 3 months ago by teor

Actual Points: 0.20.3
Keywords: tor-bridge added
Milestone: Tor: 0.4.2.x-finalTor: 0.4.1.x-final
Parent ID: #16564
Status: assignedneeds_review

We should try to get this fix in 0.4.1 if we can, it's pretty low-risk.

See my pull request https://github.com/torproject/tor/pull/1083

comment:3 Changed 2 months ago by teor

Keywords: 041-backport added

comment:4 Changed 2 months ago by dgoulet

Reviewer: nickm

comment:5 Changed 2 months ago by nickm

Keywords: 041-backport? added; 041-backport removed
Milestone: Tor: 0.4.1.x-finalTor: 0.4.2.x-final

Let's consider this in 042 first.

comment:6 Changed 2 months ago by nickm

Status: needs_reviewmerge_ready

This LGTM but I don't think it warrants a backport. Please let me know if you disagree?

comment:7 Changed 2 months ago by nickm

Keywords: dgoulet-merge added

comment:8 Changed 2 months ago by teor

Keywords: 041-backport? removed

comment:9 Changed 2 months ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

Merged to master (042)!

Note: See TracTickets for help on using tickets.