Opened 6 months ago

Closed 5 weeks ago

Last modified 5 weeks ago

#30783 closed enhancement (fixed)

End of Year Fundraising Campaign - about:tor

Reported by: pili Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ux-team, tbb-9.0, TorBrowserTeam201910R
Cc: sstevenson, antonela, emmapeel Actual Points: 2.0
Parent ID: Points: 3
Reviewer: Sponsor:

Description (last modified by pili)

Let's update about:tor in Tor Browser 9.0 stable for the End of Year Campaign.

There will (potentially) be 2 rounds of updates:

  • First round will happen around 2019-11-04 (9.0.1 release)
  • Second round will happen around 2019-12-03 (9.0.2 first security release)

Child Tickets

Attachments (2)

takeback_desktop.png (187.0 KB) - added by acat 7 weeks ago.
takeback_mobile.png (231.6 KB) - added by acat 7 weeks ago.

Download all attachments as: .zip

Change History (36)

comment:1 Changed 6 months ago by pili

Description: modified (diff)

First Round

  • Art: TBD
  • Link to: https://donate.torproject.org/
  • Proposed copy: Take back the internet. Support Tor. (and other TBD iterations)
  • Proposed functionality: Each user will see the banner three times. Any user that Xs out of the banner will not see it again. Last year the user no longer saw the banner if they clicked the link. If at all possible, I would like to remove that functionality. I suspect we had many users, visit the donation page and not complete the donation, but might complete the transaction if they have a reminder.

Second Round

  • Art: TBD
  • Link to: https://donate.torproject.org/
  • Proposed copy: TBD
  • Proposed functionality: Each user will see the banner three times. Any user that Xs out of the banner will not see it again. Last year the user no longer saw the banner if they clicked the link. If at all possible, I would like to remove that functionality. I suspect we had many users, visit the donation page and not complete the donation, but might complete the transaction if they have a reminder.

comment:2 Changed 6 months ago by pili

Cc: emmapeel added

We will need the copy to be frozen at least 2 weeks before release for translations, i.e by the first week of October for Banner 1 and by mid to end November for Banner2

comment:3 Changed 5 months ago by pili

We should review the banner dates:

[20:44:58] <+GeKo> pili: we should at some point think whether we really want to have the first EOY banner together with 9.0
[20:45:13] <+GeKo> iirc we had a similar discussion last year when launching 8.0
[20:45:22] <+GeKo> (even though that was earlier)
[20:45:49] <+GeKo> and decided against it to not distract from the major release and all we achieved back then

comment:4 Changed 5 months ago by gk

Another thing we should keep in mind is making sure the version and changelog link are still visible, even with the banner.

comment:5 in reply to:  3 Changed 5 months ago by pili

Replying to pili:

We should review the banner dates:

[20:44:58] <+GeKo> pili: we should at some point think whether we really want to have the first EOY banner together with 9.0
[20:45:13] <+GeKo> iirc we had a similar discussion last year when launching 8.0
[20:45:22] <+GeKo> (even though that was earlier)
[20:45:49] <+GeKo> and decided against it to not distract from the major release and all we achieved back then

Maybe we can try to have a release 2 weeks after 9.0 stable (mid November?) to give enough time for the first EOY fundraising banner before we switch to the second iteration in mid December.

comment:6 Changed 2 months ago by pili

Keywords: TorBrowserTeam201910 added

comment:7 Changed 2 months ago by gk

Points: 3

comment:8 Changed 2 months ago by antonela

about:tor mockups are here:

https://marvelapp.com/7f6eha5/screen/62377653 [en]

https://marvelapp.com/7f6eha5/screen/62377655 [fr]

https://marvelapp.com/7f6eha5/screen/62377654 [de]

I'd like to discuss them with the Tor Browser Team during next week's meeting.

comment:9 Changed 8 weeks ago by brade

I'm not sure if I'm seeing the correct images. The links above labeled "[fr]" and "[de]" point to pages that don't look like about:tor mockups.

The text "Give today, and Mozilla will match your donation" gets lost in the busy-ness of the purple computer.

We should provide a way for users to hide the campaign portion of the page (e.g. with an "x" button).

comment:10 Changed 8 weeks ago by antonela

Hi brade! Thanks for working on this. I made a quick markup here

https://take-back-the-internet.glitch.me/

I'm still thinking about the [x]

Last edited 8 weeks ago by antonela (previous) (diff)

comment:11 in reply to:  10 Changed 7 weeks ago by isabela

I am confused, we are not creating a banner but modifying the about page. Why we would have a way to 'x' out of the page?

Replying to antonela:

Hi brade! Thanks for working on this. I made a quick markup here

https://take-back-the-internet.glitch.me/

I'm still thinking about the [x]

comment:12 Changed 7 weeks ago by antonela

Good question. Brade came with the [X] idea and i didn't contemplate it exactly because of that.

The question is, do we want to allow users to back to the regular (purple) about:tor?

comment:13 in reply to:  12 ; Changed 7 weeks ago by isabela

Replying to antonela:

Good question. Brade came with the [X] idea and i didn't contemplate it exactly because of that.

The question is, do we want to allow users to back to the regular (purple) about:tor?

The idea of not doing the banner and just use the page was to have a cool thematic page all the time of the campaign, instead of the old multiple banner versions. Of course all the functionality of the page will stay there.

We are starting with the YE campaign theme but we do pages for a special event or campaign at another time if we think it fits doing it. Of course we won't abuse it, but it will be great to be able to use the page this way.

comment:14 in reply to:  13 Changed 7 weeks ago by antonela

Replying to isabela:

The idea of not doing the banner and just use the page was to have a cool thematic page all the time of the campaign, instead of the old multiple banner versions. Of course all the functionality of the page will stay there.

We are starting with the YE campaign theme but we do pages for a special event or campaign at another time if we think it fits doing it. Of course we won't abuse it, but it will be great to be able to use the page this way.

Got it! moving forward so :) thanks isa!

comment:15 Changed 7 weeks ago by sstevenson

Can we use the following redirects so that we can track the hits to the donate page?

/donate/donate-tbi-tb1 --- about:tor donate button (english)
/donate/donate-tbi-tb2 --- about:tor donate button (language2)
/donate/donate-tbi-tb3 --- about:tor donate button (language3)
/donate/donate-tbi-tb4 --- about:tor donate button (language4)
/donate/donate-tbi-tb5 --- about:tor donate button (language5)
/donate/donate-tbi-tb6 --- about:tor donate button (language6)
/donate/donate-tbi-tb7 --- about:tor donate button (language7)
/donate/donate-tbi-tb8 --- about:tor donate button (language8)
/donate/donate-tbi-tb9 --- about:tor donate button (language10)
/donate/donate-tbi-tb10 --- about:tor donate button (language10)
etc...for each localized language

comment:16 Changed 7 weeks ago by pili

Description: modified (diff)
Summary: End of Year Fundraising Campaign BannerEnd of Year Fundraising Campaign - about:tor

comment:17 Changed 7 weeks ago by acat

Actual Points: 1.5
Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: newneeds_review

Changes for review: https://github.com/acatarineu/torbutton/commit/30783.

sstevenson: right now setting the link as https://www.torproject.org/donate/donate-tbi-${aLocale} so /donate-tbi-en-US, /donate-tbi-es-ES, etc. Is this ok, or it would need to be exactly /donate/donate-tbi-tb1, /donate/donate-tbi-tb2, ...?

I still need to build and test in Android, but attaching a screenshot done in desktop with mobile size, I think it should look similar to that.

Changed 7 weeks ago by acat

Attachment: takeback_desktop.png added

Changed 7 weeks ago by acat

Attachment: takeback_mobile.png added

comment:18 Changed 6 weeks ago by antonela

it looks great acat!

comment:19 Changed 6 weeks ago by gk

Keywords: TorBrowserTeam201910 added; TorBrowserTeam201910R removed
Status: needs_reviewneeds_revision

Let's include the links to the fonts and the licenses as well (where they are missing). We realized that there is no LICENSE file in Torbutton at all. We should fix that while we are at it and put the EOY campaign commit on top of it.

comment:20 Changed 6 weeks ago by acat

Keywords: TorBrowserTeam201910R added; TorBrowserTeam201910 removed
Status: needs_revisionneeds_review

Revised in https://github.com/acatarineu/torbutton/commits/30783+1.

I also changed the source pro font embedded in css, took it from https://github.com/adobe-fonts/source-code-pro/blob/release/WOFF2/TTF/SourceCodePro-Regular.ttf.woff2 instead of the Google Fonts one.

Wrt the LICENSE, I used 3-clause BSD as tor and put a copyright notice on top. Is that fine or should we add year ranges for the copyright (maybe adding some other people which might have had copyright in the past?). Should we mention other license/copyright for components/cookie-jar-selector.js (this is going to be removed soon, probably)?

comment:21 in reply to:  17 Changed 6 weeks ago by sstevenson

Replying to acat:

Changes for review: https://github.com/acatarineu/torbutton/commit/30783.

sstevenson: right now setting the link as https://www.torproject.org/donate/donate-tbi-${aLocale} so /donate-tbi-en-US, /donate-tbi-es-ES, etc. Is this ok, or it would need to be exactly /donate/donate-tbi-tb1, /donate/donate-tbi-tb2, ...?

I still need to build and test in Android, but attaching a screenshot done in desktop with mobile size, I think it should look similar to that.

As long as https://www.torproject.org/donate/donate is there, the rest of the URL doesn't matter. Thanks!

comment:22 Changed 6 weeks ago by acat

I built and tested on Android, and looks good to me. Attaching the apk so it can be tested on other devices.

comment:24 Changed 6 weeks ago by acat

Sorry, didn't know this expires after one download. Here it is: https://acatarineu.keybase.pub/tor-browser-9.5a1-android-armv7-multi-qa.apk

comment:25 Changed 6 weeks ago by gk

Looks good to me, thanks. For some reason the about:tor page on my phone is not scrollable on start-up so I don't see all of the text and link to our newsletter sign-up. However, that goes away after I open a second tab switch back to the first one. So, I assume this is unrelated. I'll open a new ticket after verifying that problem in tomorrow's nightlies.

I applied the patches onto Torbutton's master (commit 1b10bf33beac6bdaad744adc3318c6d7ccdb8c72and 5e80a7f316bea85e6c01af96fea05ba57a367f06; the language strings made it already earlier in to give translators more time, in commit b75147e1d866ebe1c2be4100ba54fe2e4b7bf321) and updated the translations so we have everything working at least in all the locales we support (commit c0438bdcd48215fb73425f448ee1e5e9f5e4dbe3). I bumped tor-browser-68.2.0esr-9.5-1, too (commit 18e5f036338520c7f8ec7d2decf9007f10caaf78), so we have nightly builds tomorrow containing the changes. Provided everything still looks good, I'll backport the changes to stable as well and close this ticket.

comment:26 Changed 6 weeks ago by sstevenson

Can we add unique URLs to android so we can track clicks from that platform?

/donate/donate-tba-tb1 --- about:tor donate button (English)
/donate/donate-tba-tb2 --- about:tor donate button (language2)
/donate/donate-tba-tb3 --- about:tor donate button (language3)
/donate/donate-tba-tb4 --- about:tor donate button (language4)
/donate/donate-tba-tb5 --- about:tor donate button (language5)
/donate/donate-tba-tb6 --- about:tor donate button (language6)
/donate/donate-tba-tb7 --- about:tor donate button (language7)
/donate/donate-tba-tb8 --- about:tor donate button (language8)
/donate/donate-tba-tb9 --- about:tor donate button (language10)
/donate/donate-tba-tb10 --- about:tor donate button (language10)
etc...for each localized language

comment:27 Changed 6 weeks ago by gk

Maybe the metrics folks could check the useragent string before it gets sanitized? That would save us some work and last minute changes.

comment:28 in reply to:  27 ; Changed 5 weeks ago by sysrqb

Replying to gk:

Maybe the metrics folks could check the useragent string before it gets sanitized? That would save us some work and last minute changes.

irl confirmed we don't have access to the UAS before sanitization, so I modified the patch so it uses /donate/donate-tbi-mobile-*.

During testing, I noticed the pre-existing "Keep Tor Strong. Donate Now" link is still using the old url (directly for donate.tpo) and it seems like people may click that link instead of the large purple-and-black button. I patched this so both links use the same url.

I can see us using slightly different urls for the two links, but we can think about that for the next iteration.

comment:29 Changed 5 weeks ago by sysrqb

acat, can you review this and test it?

https://github.com/sysrqb/torbutton
branch bug30783_mobile_00

I haven't tested it on desktop yet (still building).

comment:30 in reply to:  28 ; Changed 5 weeks ago by gk

Replying to sysrqb:

Replying to gk:

Maybe the metrics folks could check the useragent string before it gets sanitized? That would save us some work and last minute changes.

irl confirmed we don't have access to the UAS before sanitization, so I modified the patch so it uses /donate/donate-tbi-mobile-*.

During testing, I noticed the pre-existing "Keep Tor Strong. Donate Now" link is still using the old url (directly for donate.tpo) and it seems like people may click that link instead of the large purple-and-black button. I patched this so both links use the same url.

I can see us using slightly different urls for the two links, but we can think about that for the next iteration.

Let's check with the fundraising folks before doing a final merge. There might be a reason for just focusing on the campaign part and leaving the general donation link as it is.

comment:31 in reply to:  29 Changed 5 weeks ago by gk

Replying to sysrqb:

acat, can you review this and test it?

https://github.com/sysrqb/torbutton
branch bug30783_mobile_00

I haven't tested it on desktop yet (still building).

This looks good to me on Linux and we get the new links on mobile. However, the locale differentiation there is busted, probably due to #32342.

The code changes look good as well. I'll wait for the fundraising people to say what they want.

comment:32 in reply to:  30 Changed 5 weeks ago by sstevenson

Replying to gk:

Replying to sysrqb:

Replying to gk:

Maybe the metrics folks could check the useragent string before it gets sanitized? That would save us some work and last minute changes.

irl confirmed we don't have access to the UAS before sanitization, so I modified the patch so it uses /donate/donate-tbi-mobile-*.

During testing, I noticed the pre-existing "Keep Tor Strong. Donate Now" link is still using the old url (directly for donate.tpo) and it seems like people may click that link instead of the large purple-and-black button. I patched this so both links use the same url.

I can see us using slightly different urls for the two links, but we can think about that for the next iteration.

Let's check with the fundraising folks before doing a final merge. There might be a reason for just focusing on the campaign part and leaving the general donation link as it is.

Using the same URL for both links is fine. Thanks!

comment:33 Changed 5 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks! We are good here then. I pushed the remaining changes to master (commits 9ea41dcdc38c79368a0909f4a64fcb865bd39af2 and ce795172f37ee2a43a8e7de0c0d06816143880ad). And pushed all of them + the ones previously landed on a new maintenance branch for Torbutton code, maint-9.0. We are done here.

sysrqb: please add your points.

comment:34 Changed 5 weeks ago by sysrqb

Actual Points: 1.52.0
Note: See TracTickets for help on using tickets.