Opened 12 months ago

Closed 6 months ago

Last modified 6 months ago

#30786 closed enhancement (fixed)

Ship Thai Tor Browser in alpha series

Reported by: emmapeel Owned by: gk
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201911R
Cc: gk, pili, tbb-team Actual Points: 0.25
Parent ID: #29935 Points: 0.25
Reviewer: Sponsor:

Description

After the localization lab sprint, the Tor Browser locale files have been translated to Thai.
please add them for testing to alpha!

Child Tickets

Change History (16)

comment:1 Changed 12 months ago by gk

Keywords: TorBrowserTeam201906 added; TorBrowserTeam201905 removed

Moving tickets to June

comment:2 Changed 11 months ago by gk

Keywords: TorBrowserTeam201907 added; TorBrowserTeam201906 removed

Moving tickets to July

comment:3 Changed 9 months ago by gk

Keywords: TorBrowserTeam201908 added; TorBrowserTeam201907 removed

Moving more tickets to August

comment:4 Changed 9 months ago by gk

Keywords: TorBrowserTeam201909 added; TorBrowserTeam201908 removed

Moving tickets to September

comment:5 Changed 9 months ago by pili

Points: 0.25

comment:6 Changed 8 months ago by pili

Keywords: TorBrowserTeam201910 added

comment:7 Changed 8 months ago by pili

Keywords: TorBrowserTeam201909 removed

comment:8 Changed 8 months ago by emmapeel

ey there!

the translators translated TBB in June, it can be a little demotivating to wait so long to see their results, is there a way to speed the addition of this translation, at least in alpha?

comment:9 in reply to:  8 ; Changed 8 months ago by gk

Replying to emmapeel:

ey there!

the translators translated TBB in June, it can be a little demotivating to wait so long to see their results, is there a way to speed the addition of this translation, at least in alpha?

Yes, there is. It would greatly speed up the process if you or someone else provided a patch for review, ideally with bundles built for all supported platforms.

We plan to do exactly that once the 9.5 alpha cycle starts and the 9.0 dust has settled. If you get to it earlier, please do.

comment:10 Changed 7 months ago by pili

Keywords: TorBrowserTeam201911 added; TorBrowserTeam201910 removed

Moving tickets to November 2019

comment:11 Changed 6 months ago by pili

Owner: changed from tbb-team to gk
Status: newassigned

assigning tickets to gk

comment:12 Changed 6 months ago by brade

Cc: tbb-team added

comment:13 Changed 6 months ago by gk

Actual Points: 0.25
Keywords: TorBrowserTeam201911R added; TorBrowserTeam201911 removed
Status: assignedneeds_review

I am seeing comment:1:ticket:30087 with the th bundle I have but that should not be a blocker. However, I fear th might suffer from #29257, too, which would be a blocker. So far the patches I have work on Android, Linux, and Windows 7.

I've uploaded a bundle for someone to test on Windows 10:

https://people.torproject.org/~gk/testbuilds/torbrowser-install-win64-tbb-nightly.2019.11.21_th.exe
https://people.torproject.org/~gk/testbuilds/torbrowser-install-win64-tbb-nightly.2019.11.21_th.exe.asc

The branches for review:
tor-browser-build: bug_30786_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_30786_v2&id=715939330d3c62b8e075af620a41e0fd48cb54b5)
tor-launcher: bug_30786 (https://gitweb.torproject.org/user/gk/tor-launcher.git/commit/?h=bug_30786&id=2a4089478815e6ff2f74b90aaf5723920d85542f)
torbutton: bug_30786 (https://gitweb.torproject.org/user/gk/torbutton.git/log/?h=bug_30786 (last two commits))

Last edited 6 months ago by gk (previous) (diff)

comment:14 in reply to:  13 Changed 6 months ago by gk

Replying to gk:

[snip]

torbutton: bug_30786 (https://gitweb.torproject.org/user/gk/torbutton.git/log/?h=bug_30786 (last two commits))

There is actually no good reason to not squash those two commits. I moved forward with that idea in bug_30786_v2 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_30786_v2&id=3f32e7dd512f579e98a998b514e8d153e8c417a9).

comment:15 in reply to:  9 Changed 6 months ago by emmapeel

Replying to gk:

Replying to emmapeel:

ey there!

the translators translated TBB in June, it can be a little demotivating to wait so long to see their results, is there a way to speed the addition of this translation, at least in alpha?

Yes, there is. It would greatly speed up the process if you or someone else provided a patch for review, ideally with bundles built for all supported platforms.

Sorry I didn't saw this before. @gk when you see this maybe you can point me to some documentation on how to do such a thing, if not this time, for next?

comment:16 Changed 6 months ago by sysrqb

Resolution: fixed
Status: needs_reviewclosed

Patches seem good, thanks.

Picked as:
torbutton: 5c87af5b0cee66f919e233d30a8dfec89c712222
tor-launcher: 39e7de2065d9fb6be0ed859844e97ead758fd7aa
tor-browser-build: 73c2848ca10144988aff74a2a233171cb8624a23

Note: See TracTickets for help on using tickets.