Opened 14 months ago

Closed 8 months ago

#30788 closed enhancement (fixed)

Ship Malay (ms) Tor Browser in alpha series

Reported by: emmapeel Owned by: gk
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201911R
Cc: gk, pili, tbb-team, emmapeel Actual Points: 0.25
Parent ID: #29935 Points: 0.25
Reviewer: Sponsor:

Description

We can add this to test to alpha. yay!

Child Tickets

Change History (14)

comment:1 Changed 14 months ago by gk

Keywords: TorBrowserTeam201906 added; TorBrowserTeam201905 removed

Moving tickets to June

comment:2 Changed 13 months ago by gk

Keywords: TorBrowserTeam201907 added; TorBrowserTeam201906 removed

Moving tickets to July

comment:3 Changed 12 months ago by gk

Keywords: TorBrowserTeam201908 added; TorBrowserTeam201907 removed

Moving more tickets to August

comment:4 Changed 11 months ago by gk

Keywords: TorBrowserTeam201909 added; TorBrowserTeam201908 removed

Moving tickets to September

comment:5 Changed 11 months ago by pili

Points: 0.25

comment:6 Changed 11 months ago by pili

Keywords: TorBrowserTeam201910 added

comment:7 Changed 11 months ago by pili

Keywords: TorBrowserTeam201909 removed

comment:8 Changed 9 months ago by pili

Keywords: TorBrowserTeam201911 added; TorBrowserTeam201910 removed

Moving tickets to November 2019

comment:9 Changed 9 months ago by pili

Owner: changed from tbb-team to gk
Status: newassigned

assigning tickets to gk

comment:10 Changed 9 months ago by brade

Cc: tbb-team added

comment:11 Changed 9 months ago by gk

Cc: emmapeel added

Okay, before we can move forward here we need to fix our translations infrastructure as there a no placeholder strings for missing strings in ms for some reason which results in Tor Browser crashing during start-up.

comment:12 Changed 9 months ago by gk

Actual Points: 0.25
Keywords: TorBrowserTeam201911R added; TorBrowserTeam201911 removed
Status: assignedneeds_review

Okay, the problem was that ms-MY was used by the translator for the strings but there was ms, too, which had some missing. Now things look good. Here are the patched for review:
torbutton: bug_30788 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_30788&id=23384413a31148a41856557b1632e8eb1e4d2f3d)
tor-launcher: (https://gitweb.torproject.org/user/gk/tor-launcher.git/commit/?h=bug_30788&id=ec26d714fab1b6431646fce93fb94160e210d96d)
tor-browser-build: bug_30788_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_30788_v2&id=e1b07e3ee6b7c47fe72b1e187909598081b5efdd)

comment:13 Changed 9 months ago by sysrqb

Patches seem good, thanks.

Picked these as:
torbutton: 76d6e2134380bd557ee2781f9c6f98bc92759e45
tor-launcher: da665a967ad2382b69779ce4a83825dd5b29467c
tor-browser-build: 5433d1992cf2fe33570ec00f73609756d2afc6f8

comment:14 Changed 8 months ago by gk

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.