Opened 5 months ago

Closed 5 months ago

#30840 closed defect (fixed)

Stop hard-coding the bash path in the git scripts

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version: Tor: 0.4.0.1-alpha
Severity: Normal Keywords: fast-fix, git-scripts, nickm-merge, asn-merge
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: dgoulet Sponsor:

Description

Some OSes (BSD) don't install bash by default. Others (macOS) have an ancient version of bash, which is too old for our git scripts.

Child Tickets

TicketStatusOwnerSummaryComponent
#30841closedteorAllow TOR_MASTER_NAME and TOR_WKT_NAME to be overridden in the git scriptsCore Tor/Tor

Change History (4)

comment:1 Changed 5 months ago by teor

Reviewer: dgoulet
Status: assignedneeds_review

See my pull request:
https://github.com/torproject/tor/pull/1099

It's based on #30822 and includes #30841.

I'm guessing that dgoulet might want to review these small changes.

If we merge these changes with #30822, then we all only have to update once.

comment:2 Changed 5 months ago by dgoulet

Keywords: nickm-merge asn-merge added

Great stuff!

comment:3 Changed 5 months ago by dgoulet

Status: needs_reviewmerge_ready

comment:4 Changed 5 months ago by asn

Resolution: fixed
Status: merge_readyclosed

Oh nice I needed that. Merged!

Note: See TracTickets for help on using tickets.