Opened 6 months ago

Closed 4 months ago

Last modified 4 months ago

#30845 closed defect (fixed)

Make sure default Firefox themes are enabled on ESR68

Reported by: acat Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff68-esr, TorBrowserTeam201908R, tbb-9.0-must-alpha
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor44-can

Description

With current 000-tor-browser.js prefs default theme extensions are not installed. AddonManager.maybeInstallBuiltinAddon is used to install these, which requires enabledScopes to have flag 4 (application scope). So changing extensions.enabledScopes from 1 to 5 fixes this.

My understanding is that this should only allow installing extensions from application directory, which we control. Is there any reason not to do this change?

Also, some related prefs seem obsolete:

extensions.bootstrappedAddons
extensions.enabledAddons
extensions.enabledItems

We could also use this to clean them up.

Child Tickets

Change History (7)

comment:1 Changed 4 months ago by pili

Sponsor: Sponsor44-can

Adding Sponsor 44 to ESR68 tickets

comment:2 Changed 4 months ago by acat

This also fixes the issue in current esr68 nightly that search engine icons disappear after restarting the Tor Browser. Note that the value extensions.enabledScopes = 5 comes from (AddonManager.SCOPE_PROFILE=1 | AddonManager.SCOPE_APPLICATION=4).

comment:3 Changed 4 months ago by gk

Keywords: TorBrowserTeam201908 tbb-9.0-must-alpha added

comment:4 Changed 4 months ago by acat

Keywords: TorBrowserTeam201908R added; TorBrowserTeam201908 removed
Status: newneeds_review

comment:5 Changed 4 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me. Cherry-picked onto tor-browser-68.1.0esr-9.0-1 (commit 3b423362d6729d76b0c79274f52972346900c4fc).

comment:7 Changed 4 months ago by cypherpunks

tbb-parity achieved.

Note: See TracTickets for help on using tickets.