Opened 2 months ago

Last modified 3 days ago

#30845 new defect

Make sure default Firefox themes are enabled on ESR68

Reported by: acat Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff68-esr
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor44-can

Description

With current 000-tor-browser.js prefs default theme extensions are not installed. AddonManager.maybeInstallBuiltinAddon is used to install these, which requires enabledScopes to have flag 4 (application scope). So changing extensions.enabledScopes from 1 to 5 fixes this.

My understanding is that this should only allow installing extensions from application directory, which we control. Is there any reason not to do this change?

Also, some related prefs seem obsolete:

extensions.bootstrappedAddons
extensions.enabledAddons
extensions.enabledItems

We could also use this to clean them up.

Child Tickets

Change History (2)

comment:1 Changed 12 days ago by pili

Sponsor: Sponsor44-can

Adding Sponsor 44 to ESR68 tickets

comment:2 Changed 3 days ago by acat

This also fixes the issue in current esr68 nightly that search engine icons disappear after restarting the Tor Browser. Note that the value extensions.enabledScopes = 5 comes from (AddonManager.SCOPE_PROFILE=1 | AddonManager.SCOPE_APPLICATION=4).

Note: See TracTickets for help on using tickets.