Opened 4 months ago

Last modified 2 weeks ago

#30867 assigned defect

Write proxy-go tests to cover existing implementation

Reported by: cohosh Owned by: cohosh
Priority: Medium Milestone:
Component: Circumvention/Snowflake Version:
Severity: Normal Keywords: tests, anti-censorship-roadmap-september
Cc: arlolra, cohosh, phw, dcf Actual Points:
Parent ID: #29259 Points: 2
Reviewer: Sponsor: Sponsor28


Currently we only have proxy-go tests to test extracting the client's remote IP from the SDP offer.

We should increase test coverage.

Child Tickets

Change History (4)

comment:1 Changed 4 months ago by cohosh

Owner: set to cohosh
Status: newassigned

Here's a start:

I refactored some of the proxy-go code to use an http.RoundTripper to communicate with the broker. I think it looks a bit cleaner this way in addition to making tests easier.

comment:2 Changed 4 months ago by dcf

Looks good so far. The http.RoundTripper makes sense. RoundTrip is slightly different than Do in that it doesn't follow redirects, but I think we want RoundTrip behavior anyway.

comment:3 Changed 3 months ago by gaba

Keywords: anti-censorship-roadmap-september added; snowflake removed
Points: 2

comment:4 Changed 2 weeks ago by cohosh

I rebased these tests after merging #28942, but I'm going to put this on hold until we merge #29207 since that makes significant changes to how the proxies communicate with the broker and will therefore require further changes to the tests.

Note: See TracTickets for help on using tickets.