Modify client rendezvous library to remove hard-coded responses

Client tests rely of client/lib/rendezvous.go rely on specific HTTP response bodies which are prone to change and unnecessary

changed milestone to %Tor: unspecified

Trac:
Parent Ticket: #29259 (moved)

added component::circumvention/snowflake easy ex-sponsor-19 milestone::Tor: unspecified parent::29259 priority::medium resolution::not a bug severity::normal sponsor::28 status::closed type::defect version::tor unspecified labels

To be more specific, I was thinking of

        BrokerError503        string = "No snowflake proxies currently available."
        BrokerError400        string = "You sent an invalid offer in the request."
        BrokerErrorUnexpected string = "Unexpected error, no answer."

but on closer look, I don't see any problems with this. Closing.

Trac:
Status: new to closed
Resolution: N/A to not a bug

I thought the problem was just in some tests. I am not sure, but it looks like this test is checking the for the literal string "No snowflake proxies currently available." rather than a status code of 503.

		Convey("BrokerChannel.Negotiate fails with 503", func() {
			b := NewBrokerChannel("test.broker", "",
				&MockTransport{http.StatusServiceUnavailable, []byte("\n")})
			answer, err := b.Negotiate(fakeOffer)
			So(err, ShouldNotBeNil)
			So(answer, ShouldBeNil)
			So(err.Error(), ShouldResemble, BrokerError503)
		})

Replying to dcf:

it looks like this test is checking the for the literal string "No snowflake proxies currently available." rather than a status code of 503.

No, I was mistaken. The test is just checking the text of the error message, which is okay. The broker returns an empty body for status 503, and here is where the status codes get translated into error strings.

	case http.StatusServiceUnavailable:
		return nil, errors.New(BrokerError503)
	case http.StatusBadRequest:
		return nil, errors.New(BrokerError400)

closed

mentioned in issue #29259 (moved)

moved to tpo/anti-censorship/pluggable-transports/snowflake#30868 (closed)