Opened 6 months ago

Closed 3 weeks ago

Last modified 3 weeks ago

#30888 closed defect (fixed)

Minimize torbutton globals exposed in browser window

Reported by: acat Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-torbutton, TorBrowserTeam201911
Cc: Actual Points: 1
Parent ID: #28745 Points:
Reviewer: Sponsor:

Description

Right now there are a number of variables and functions that are exposed globally in the browser window, from chrome/content/{tor-circuit-display.js,torbutton_util.js,torbutton.js}. We should make sure the globally available symbols are only the strictly necessary.

Child Tickets

Change History (2)

comment:1 Changed 3 weeks ago by gk

Keywords: TorBrowserTeam201911 added
Resolution: fixed
Status: newclosed

The changes in your #28475 branches look good to me. I cherry-picked the Torbutton change to master (commit ed3fafebab28d005e22208aa921e5f5c7c54153f) and the tor-browser change to tor-browser-68.2.0esr-9.5-1 (commit 8f2ba127875371bfa707525d0778942587daf87c).

acat: please add your points you spent on this one.

comment:2 Changed 3 weeks ago by acat

Actual Points: 1
Note: See TracTickets for help on using tickets.