Opened 5 weeks ago

Closed 3 weeks ago

#30889 closed defect (fixed)

Eliminate some uses of lower-level control protocol output functions

Reported by: catalyst Owned by: catalyst
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: asn-merge
Cc: Actual Points: 3
Parent ID: #29210 Points: 3
Reviewer: nickm Sponsor: Sponsor31-can

Description

Continuing the work of #30007, refactor more control.c stuff to stop using lower-level control protocol output functions like connection_write_str_to_buf(), connection_printf_to_buf(), and connection_buf_add().

Child Tickets

Change History (6)

comment:1 Changed 4 weeks ago by catalyst

Status: assignedaccepted

comment:2 Changed 3 weeks ago by catalyst

Summary: Eliminate use of lower-level control protocol output functionsEliminate some uses of lower-level control protocol output functions

It turns out to be easier to fix up the onion_helper stuff first as a separate commit. Opening a new ticket for sending control replies using a key-value list abstraction.

comment:3 Changed 3 weeks ago by catalyst

Actual Points: 3
Status: acceptedneeds_review

comment:4 Changed 3 weeks ago by nickm

Reviewer: nickm

comment:5 Changed 3 weeks ago by nickm

Keywords: asn-merge added
Status: needs_reviewmerge_ready

This branch LGTM. I note that the stem test in travis is passing, which is a good thing to check with a branch that affects the controller code.

comment:6 Changed 3 weeks ago by asn

Resolution: fixed
Status: merge_readyclosed

Pushed to master.

Note: See TracTickets for help on using tickets.