Opened 5 weeks ago

Last modified 5 weeks ago

#30899 new enhancement

Include the commit hash in the sbws version

Reported by: teor Owned by:
Priority: Medium Milestone: sbws: 1.2.x-final
Component: Core Tor/sbws Version:
Severity: Normal Keywords:
Cc: juga Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor:

Description

When we put the sbws version in the bandwidth file, we should include the git commit hash.
That helps us tell dev versions apart.

Child Tickets

Change History (2)

comment:1 Changed 5 weeks ago by teor

See https://trac.torproject.org/projects/tor/ticket/30733#comment:21 for one time we wanted this feature.

comment:2 Changed 5 weeks ago by teor

Here's one way we could do this feature:

Add a software_commit key to the bandwidth file header.
If git is installed at runtime (or install time), make the header value "git-(commit hash)".
Here's how PrivCout does it in python:
https://github.com/privcount/privcount/blob/master/privcount/protocol.py#L33

We should also show the git commit hash when we print the sbws version in the log.

Note: See TracTickets for help on using tickets.