Opened 6 months ago

Last modified 6 months ago

#30902 new defect

Stop comparing file_created key in test

Reported by: juga Owned by:
Priority: Medium Milestone: sbws: unspecified
Component: Core Tor/sbws Version: sbws: 1.1.0
Severity: Normal Keywords: ci, tests
Cc: juga Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor:

Description

In concrete tests/unit/lib/v3bwfile.py::test_from_results_read.
Because some times it files with the second: https://travis-ci.org/juga0/sbws/jobs/546378459#L1339.

Child Tickets

Change History (3)

comment:1 Changed 6 months ago by juga

Also tests/integration/lib/test_relaylist.py::test_relay_list_last_consensus_timestamp fails some times: (https://travis-ci.org/torproject/sbws/jobs/546604904#L1945)

comment:2 in reply to:  1 Changed 6 months ago by teor

Replying to juga:

Also tests/integration/lib/test_relaylist.py::test_relay_list_last_consensus_timestamp fails some times: (https://travis-ci.org/torproject/sbws/jobs/546604904#L1945)

This might be fixed by #30909. There is a bug in the last consensus time update code.

comment:3 in reply to:  description Changed 6 months ago by teor

Replying to juga:

In concrete tests/unit/lib/v3bwfile.py::test_from_results_read.
Because some times it files with the second: https://travis-ci.org/juga0/sbws/jobs/546378459#L1339.

One way to fix this bug is to pass a time to the bandwidth file creation function.
Or mock the time that the bandwidth file creation function uses in the bandwidth file.

Note: See TracTickets for help on using tickets.