Opened 14 months ago

Closed 7 months ago

#30909 closed defect (fixed)

sbws consensus timestamp updates incorrectly use the current time

Reported by: teor Owned by:
Priority: Medium Milestone: sbws: 1.1.x-final
Component: Core Tor/sbws Version: sbws: 1.1.0
Severity: Normal Keywords: sbws-ci-fail-sometimes
Cc: juga Actual Points: 0.2
Parent ID: #30733 Points: 0.2
Reviewer: juga Sponsor:

Description

There is a race condition in the sbws relay consensus timestamp update code.

sbws uses the current timestamp (now) when the same consensus is retrieved twice. Instead, it should just keep the same (valid-after) timestamp.

Child Tickets

Change History (8)

comment:1 Changed 14 months ago by teor

Reviewer: juga
Status: assignedneeds_review

See my pull request:
https://github.com/torproject/sbws/pull/360

It checks the valid-after time and the timestamp in the same way, so this bug shouldn't happen any more. If it does, we should fix the test code.

comment:2 Changed 13 months ago by juga

Status: needs_reviewmerge_ready

lgtm, just added a comment regarding the commit.

comment:3 Changed 13 months ago by juga

Status: merge_readyneeds_review

I realized about other bug, fixed in https://github.com/juga0/sbws/commits/bug30909_11.
I'm not sure which the workflow should be here, so just changing this ticket to needs review, but not doing PR nor assigning reviewer.

comment:4 Changed 11 months ago by teor

Status: needs_reviewneeds_revision

comment:5 Changed 11 months ago by teor

Owner: teor deleted
Status: needs_revisionassigned

I am not actively working on this ticket

comment:6 Changed 11 months ago by teor

Status: assignedneeds_revision

comment:7 in reply to:  3 Changed 7 months ago by juga

Status: needs_revisionmerge_ready

Replying to juga:

I realized about other bug, fixed in https://github.com/juga0/sbws/commits/bug30909_11.
I'm not sure which the workflow should be here, so just changing this ticket to needs review, but not doing PR nor assigning reviewer.

Since this ticket is blocking #30733 and the potential bug it's not related to teor's patch, i've created #33060 for it and changing this one to merge ready.

comment:8 Changed 7 months ago by juga

Resolution: fixed
Status: merge_readyclosed

Merged

Note: See TracTickets for help on using tickets.